redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

usb: fix breakage on systems without ACPI 

Commit da0af6e ("usb: Bind devices to ACPI devices when possible") really
tries to force-bind devices even when impossible, unlike what it says in
the subject.

CONFIG_ACPI is not an indication that ACPI tables are actually present, nor
is an indication that any USB relevant information is present in them. There
is no reason to fail the creation of a USB bus if it can't bind it to
ACPI device during initialization.

On systems with CONFIG_ACPI set but without ACPI tables it would cause a
boot panic.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Sasha Levin 2012-05-16 14:11:15 +02:00 committed by Greg Kroah-Hartman
parent e4083ea5a7
commit ea79c2ed6e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/core/usb.c
View File

@ -1015,9 +1015,7 @@ static int __init usb_init(void)
if (retval)
goto out;
retval = usb_acpi_register();
if (retval)
goto acpi_register_failed;
usb_acpi_register();
retval = bus_register(&usb_bus_type);
if (retval)
goto bus_register_failed;
@ -1053,7 +1051,6 @@ bus_notifier_failed:
bus_unregister(&usb_bus_type);
bus_register_failed:
usb_acpi_unregister();
acpi_register_failed:
usb_debugfs_cleanup();
out:
return retval;