redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

regulator: axp20x: remove a redundant null check on rdev 

Currently rdev is dereferenced when assigning desc before rdev is null
checked, this is leading to static analysis warnings.  However, rdev
can never be null, so the null check is redundant and can be removed.

Detected by CoverityScan, CID#1476031 ("Dereference before null check")

Fixes: 77e3e3b165 ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Colin Ian King 2019-02-15 09:45:54 +00:00 committed by Mark Brown
parent afb29714ac
commit ea7b971cd6
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/regulator/axp20x-regulator.c
View File

@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
const int *slew_rates;
int rate_count = 0;
if (!rdev)
return -EINVAL;
desc = rdev->desc;
switch (axp20x->variant) {