redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

Btrfs: avoid double free of fs_info->qgroup_ulist 

When btrfs_read_qgroup_config or btrfs_quota_enable return non-zero, we've
already freed the fs_info->qgroup_ulist. The final btrfs_free_qgroup_config
called from quota_disable makes another ulist_free(fs_info->qgroup_ulist)
call.

We set fs_info->qgroup_ulist to NULL on the mentioned error paths, turning
the ulist_free in btrfs_free_qgroup_config into a noop.

Cc: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
hifive-unleashed-5.1
Jan Schmidt 2013-05-28 15:47:23 +00:00 committed by Josef Bacik
parent 4373519db4
commit eb1716af88
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/btrfs/qgroup.c
View File

@ -430,8 +430,10 @@ out:
}
btrfs_free_path(path);
if (ret < 0)
if (ret < 0) {
ulist_free(fs_info->qgroup_ulist);
fs_info->qgroup_ulist = NULL;
}
return ret < 0 ? ret : 0;
}
@ -932,8 +934,10 @@ out_free_root:
kfree(quota_root);
}
out:
if (ret)
if (ret) {
ulist_free(fs_info->qgroup_ulist);
fs_info->qgroup_ulist = NULL;
}
mutex_unlock(&fs_info->qgroup_ioctl_lock);
return ret;
}