1
0
Fork 0

[PATCH] libata: disable failed devices only once in ata_bus_probe()

Devices which consumed all their changes used to be disabled every
iteration.  This causes unnecessary noise in the console output.
Disable once and leave alone.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
hifive-unleashed-5.1
Tejun Heo 2006-04-11 22:26:29 +09:00 committed by Jeff Garzik
parent 7dd29dd629
commit ec573755fc
1 changed files with 7 additions and 5 deletions

View File

@ -1411,12 +1411,9 @@ static int ata_bus_probe(struct ata_port *ap)
/* read IDENTIFY page and configure devices */
for (i = 0; i < ATA_MAX_DEVICES; i++) {
dev = &ap->device[i];
dev->class = classes[i];
if (!tries[i]) {
ata_down_xfermask_limit(ap, dev, 1);
ata_dev_disable(ap, dev);
}
if (tries[i])
dev->class = classes[i];
if (!ata_dev_enabled(dev))
continue;
@ -1477,6 +1474,11 @@ static int ata_bus_probe(struct ata_port *ap)
tries[dev->devno] = 0;
}
if (!tries[dev->devno]) {
ata_down_xfermask_limit(ap, dev, 1);
ata_dev_disable(ap, dev);
}
goto retry;
}