redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

regulator: max77686: Consistently index opmode array by rdev id 

Mixed indexes were used for array of opmodes in max77686_data structure:
id of regulator and index of regulator_desc array.

These indexes are exactly the same but the mixture may confuse. Use
consistently the id of regulator.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Krzysztof Kozlowski 2014-11-04 09:49:41 +01:00 committed by Mark Brown
parent 78ce612860
commit eca29da9a2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/regulator/max77686.c
View File

@ -82,6 +82,7 @@ enum max77686_ramp_rate {
};
struct max77686_data {
/* Array indexed by regulator id */
unsigned int opmode[MAX77686_REGULATORS];
};
@ -513,12 +514,13 @@ static int max77686_pmic_probe(struct platform_device *pdev)
for (i = 0; i < MAX77686_REGULATORS; i++) {
struct regulator_dev *rdev;
int id = regulators[i].id;
config.init_data = pdata->regulators[i].initdata;
config.of_node = pdata->regulators[i].of_node;
max77686->opmode[i] = regulators[i].enable_mask >>
max77686_get_opmode_shift(i);
max77686->opmode[id] = regulators[i].enable_mask >>
max77686_get_opmode_shift(id);
rdev = devm_regulator_register(&pdev->dev,
&regulators[i], &config);
if (IS_ERR(rdev)) {