brcmfmac: use vmalloc to allocate mem for the firmware
The firmware is more than 300KB big and you should not use kmalloc for such big allocations. This allocation with kmalloc failed on my mips based device (BCM47186). Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Acked-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
885ba1da68
commit
edb9bc9a1e
|
@ -28,6 +28,7 @@
|
||||||
#include <linux/uaccess.h>
|
#include <linux/uaccess.h>
|
||||||
#include <linux/firmware.h>
|
#include <linux/firmware.h>
|
||||||
#include <linux/usb.h>
|
#include <linux/usb.h>
|
||||||
|
#include <linux/vmalloc.h>
|
||||||
#include <net/cfg80211.h>
|
#include <net/cfg80211.h>
|
||||||
|
|
||||||
#include <defs.h>
|
#include <defs.h>
|
||||||
|
@ -1239,7 +1240,7 @@ static int brcmf_usb_get_fw(struct brcmf_usbdev_info *devinfo)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
devinfo->image = kmalloc(fw->size, GFP_ATOMIC); /* plus nvram */
|
devinfo->image = vmalloc(fw->size); /* plus nvram */
|
||||||
if (!devinfo->image)
|
if (!devinfo->image)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
@ -1602,7 +1603,7 @@ static struct usb_driver brcmf_usbdrvr = {
|
||||||
void brcmf_usb_exit(void)
|
void brcmf_usb_exit(void)
|
||||||
{
|
{
|
||||||
usb_deregister(&brcmf_usbdrvr);
|
usb_deregister(&brcmf_usbdrvr);
|
||||||
kfree(g_image.data);
|
vfree(g_image.data);
|
||||||
g_image.data = NULL;
|
g_image.data = NULL;
|
||||||
g_image.len = 0;
|
g_image.len = 0;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue