redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] gspca: print small buffers via %*ph

Browse source 
Instead of passing each byte through stack let's use %*ph specifier to do this
job better.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Andy Shevchenko 2013-09-03 09:31:37 -03:00 committed by Mauro Carvalho Chehab
parent 76e059874d
commit ee35fa2267
2 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/media/usb/gspca/sonixb.c
View file

@ -513,10 +513,7 @@ static void i2c_w(struct gspca_dev *gspca_dev, const u8 *buf)
if (gspca_dev->usb_buf[0] & 0x04) { if (gspca_dev->usb_buf[0] & 0x04) {
if (gspca_dev->usb_buf[0] & 0x08) { if (gspca_dev->usb_buf[0] & 0x08) {
dev_err(gspca_dev->v4l2_dev.dev, dev_err(gspca_dev->v4l2_dev.dev,
"i2c error writing %02x %02x %02x %02x" "i2c error writing %8ph\n", buf);
" %02x %02x %02x %02x\n",
buf[0], buf[1], buf[2], buf[3],
buf[4], buf[5], buf[6], buf[7]);
gspca_dev->usb_err = -EIO; gspca_dev->usb_err = -EIO;
} }
return; return;

12
drivers/media/usb/gspca/xirlink_cit.c
View file

@ -2864,20 +2864,16 @@ static u8 *cit_find_sof(struct gspca_dev *gspca_dev, u8 *data, int len)
if (data[i] == 0xff) { if (data[i] == 0xff) {
if (i >= 4) if (i >= 4)
PDEBUG(D_FRAM, PDEBUG(D_FRAM,
"header found at offset: %d: %02x %02x 00 %02x %02x %02x\n", "header found at offset: %d: %02x %02x 00 %3ph\n",
i - 1, i - 1,
data[i - 4], data[i - 4],
data[i - 3], data[i - 3],
data[i], &data[i]);
data[i + 1],
data[i + 2]);
else else
PDEBUG(D_FRAM, PDEBUG(D_FRAM,
"header found at offset: %d: 00 %02x %02x %02x\n", "header found at offset: %d: 00 %3ph\n",
i - 1, i - 1,
data[i], &data[i]);
data[i + 1],
data[i + 2]);
return data + i + (sd->sof_len - 1); return data + i + (sd->sof_len - 1);
} }
break; break;