redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/nouveau/nvif: return null pointers on failure, in addition to ret != 0 

Reported by Coverity.  The intention is that the return value is
checked, but let's be more paranoid and make it extremely obvious
if something forgets to.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
hifive-unleashed-5.1
Ben Skeggs 2014-08-12 22:56:09 +10:00
parent 147ed897e8
commit ef07ceae02
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/nouveau/nvif/notify.c
View File

@ -237,8 +237,10 @@ nvif_notify_new(struct nvif_object *object, int (*func)(struct nvif_notify *),
if (notify) {
int ret = nvif_notify_init(object, nvif_notify_del, func, work,
type, data, size, reply, notify);
if (ret)
if (ret) {
kfree(notify);
notify = NULL;
}
*pnotify = notify;
return ret;
}

4
drivers/gpu/drm/nouveau/nvif/object.c
View File

@ -275,8 +275,10 @@ nvif_object_new(struct nvif_object *parent, u32 handle, u32 oclass,
if (object) {
int ret = nvif_object_init(parent, nvif_object_del, handle,
oclass, data, size, object);
if (ret)
if (ret) {
kfree(object);
object = NULL;
}
*pobject = object;
return ret;
}