From ef17a97b4bf5d25bd5e58744bfa15c39bcb80142 Mon Sep 17 00:00:00 2001 From: Iuliana Prodan Date: Fri, 21 Aug 2020 17:31:24 +0300 Subject: [PATCH] MLK-24517-2 crypto: caam - removed unnecessary validation of black key for blob encapsulation The address of an array is never NULL, so the comparison of black key array always evaluate the same way. Remove unnecessary check. Reported-by: Coverity 10893157 Signed-off-by: Iuliana Prodan Reviewed-by: Franck LENORMAND (cherry picked from commit 8888926c54e819dd7f5d00bad8abdcb8175e8bf6) --- drivers/crypto/caam/caamkeyblob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caamkeyblob.c b/drivers/crypto/caam/caamkeyblob.c index 16841dd68ea5..5551f6725d79 100644 --- a/drivers/crypto/caam/caamkeyblob.c +++ b/drivers/crypto/caam/caamkeyblob.c @@ -379,7 +379,7 @@ int caam_blob_encap(struct device *dev, struct keyblob_info *info) trusted_key = (info->type >> TAG_OBJ_TK_OFFSET) & 0x1; /* Validate input data*/ - if (!info->black_key || !info->key_mod || !blob) + if (!info->key_mod || !blob) return -EINVAL; /* Validate object type - only JDKEK keys are supported */