redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

drm/amdgpu/dce10: Move hotspot handling out of set_cursor

Browse source 
It's only needed in dce10 crtc_cursor_set2.

Port of radeon commit:
2e007e611b

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Alex Deucher 2015-09-24 17:46:19 -04:00
parent dd0b5d2f88
commit ef67e38cfe
1 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
View file

@ -2537,8 +2537,7 @@ static int dce_v10_0_cursor_move_locked(struct drm_crtc *crtc,
return 0; return 0;
} }
static int dce_v10_0_set_cursor(struct drm_crtc *crtc, struct drm_gem_object *obj, static int dce_v10_0_set_cursor(struct drm_crtc *crtc, struct drm_gem_object *obj)
int hot_x, int hot_y)
{ {
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc); struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
struct amdgpu_device *adev = crtc->dev->dev_private; struct amdgpu_device *adev = crtc->dev->dev_private;
@ -2560,19 +2559,6 @@ static int dce_v10_0_set_cursor(struct drm_crtc *crtc, struct drm_gem_object *ob
WREG32(mmCUR_SURFACE_ADDRESS + amdgpu_crtc->crtc_offset, WREG32(mmCUR_SURFACE_ADDRESS + amdgpu_crtc->crtc_offset,
lower_32_bits(gpu_addr)); lower_32_bits(gpu_addr));
if (hot_x != amdgpu_crtc->cursor_hot_x ||
hot_y != amdgpu_crtc->cursor_hot_y) {
int x, y;
x = amdgpu_crtc->cursor_x + amdgpu_crtc->cursor_hot_x - hot_x;
y = amdgpu_crtc->cursor_y + amdgpu_crtc->cursor_hot_y - hot_y;
dce_v10_0_cursor_move_locked(crtc, x, y);
amdgpu_crtc->cursor_hot_x = hot_x;
amdgpu_crtc->cursor_hot_y = hot_y;
}
return 0; return 0;
fail: fail:
@ -2628,7 +2614,21 @@ static int dce_v10_0_crtc_cursor_set2(struct drm_crtc *crtc,
amdgpu_crtc->cursor_height = height; amdgpu_crtc->cursor_height = height;
dce_v10_0_lock_cursor(crtc, true); dce_v10_0_lock_cursor(crtc, true);
ret = dce_v10_0_set_cursor(crtc, obj, hot_x, hot_y);
if (hot_x != amdgpu_crtc->cursor_hot_x ||
hot_y != amdgpu_crtc->cursor_hot_y) {
int x, y;
x = amdgpu_crtc->cursor_x + amdgpu_crtc->cursor_hot_x - hot_x;
y = amdgpu_crtc->cursor_y + amdgpu_crtc->cursor_hot_y - hot_y;
dce_v10_0_cursor_move_locked(crtc, x, y);
amdgpu_crtc->cursor_hot_x = hot_x;
amdgpu_crtc->cursor_hot_y = hot_y;
}
ret = dce_v10_0_set_cursor(crtc, obj);
if (ret) if (ret)
DRM_ERROR("dce_v10_0_set_cursor returned %d, not changing cursor\n", DRM_ERROR("dce_v10_0_set_cursor returned %d, not changing cursor\n",
ret); ret);
@ -2663,9 +2663,7 @@ static void dce_v10_0_cursor_reset(struct drm_crtc *crtc)
dce_v10_0_cursor_move_locked(crtc, amdgpu_crtc->cursor_x, dce_v10_0_cursor_move_locked(crtc, amdgpu_crtc->cursor_x,
amdgpu_crtc->cursor_y); amdgpu_crtc->cursor_y);
ret = dce_v10_0_set_cursor(crtc, amdgpu_crtc->cursor_bo, ret = dce_v10_0_set_cursor(crtc, amdgpu_crtc->cursor_bo);
amdgpu_crtc->cursor_hot_x,
amdgpu_crtc->cursor_hot_y);
if (ret) if (ret)
DRM_ERROR("dce_v10_0_set_cursor returned %d, not showing " DRM_ERROR("dce_v10_0_set_cursor returned %d, not showing "
"cursor\n", ret); "cursor\n", ret);