fbdev: exynos: fix IS_ERR_VALUE usage
IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
parent
206fc20598
commit
f059c4b220
|
@ -402,12 +402,12 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
|
||||||
dsim->irq = platform_get_irq(pdev, 0);
|
ret = platform_get_irq(pdev, 0);
|
||||||
if (IS_ERR_VALUE(dsim->irq)) {
|
if (ret < 0) {
|
||||||
dev_err(&pdev->dev, "failed to request dsim irq resource\n");
|
dev_err(&pdev->dev, "failed to request dsim irq resource\n");
|
||||||
ret = -EINVAL;
|
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
dsim->irq = ret;
|
||||||
|
|
||||||
init_completion(&dsim_wr_comp);
|
init_completion(&dsim_wr_comp);
|
||||||
init_completion(&dsim_rd_comp);
|
init_completion(&dsim_rd_comp);
|
||||||
|
|
Loading…
Reference in a new issue