redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: of: Normalize return code variable name

Browse source 
It is confusing to name return variables mixedly "status",
"err" or "ret". I just changed them all to "ret", by personal
preference, to lower cognitive stress.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20190716115854.12098-1-linus.walleij@linaro.org
This commit is contained in:
Linus Walleij 2019-07-16 13:58:54 +02:00
parent d377f56f34
commit f0d1ab0526
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/gpio/gpiolib-of.c
View file

@ -848,7 +848,7 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip) { return 0; }
int of_gpiochip_add(struct gpio_chip *chip)
{
int status;
int ret;
if (!chip->of_node)
return 0;
@ -863,9 +863,9 @@ int of_gpiochip_add(struct gpio_chip *chip)
of_gpiochip_init_valid_mask(chip);
status = of_gpiochip_add_pin_range(chip);
if (status)
return status;
ret = of_gpiochip_add_pin_range(chip);
if (ret)
return ret;
/* If the chip defines names itself, these take precedence */
if (!chip->names)
@ -874,13 +874,13 @@ int of_gpiochip_add(struct gpio_chip *chip)
of_node_get(chip->of_node);
status = of_gpiochip_scan_gpios(chip);
if (status) {
ret = of_gpiochip_scan_gpios(chip);
if (ret) {
of_node_put(chip->of_node);
gpiochip_remove_pin_ranges(chip);
}
return status;
return ret;
}
void of_gpiochip_remove(struct gpio_chip *chip)