redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: unisys: refactor initialize_controlvm_payload_info() 

Fix the CamelCased goto label:

Away => cleanup

and get rid of the NULL comparison.

Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Benjamin Romer 2015-03-16 13:58:26 -04:00 committed by Greg Kroah-Hartman
parent 61715c8b9c
commit f118a39bfe
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/unisys/visorchipset/visorchipset_main.c
View File

@ -1269,26 +1269,26 @@ initialize_controlvm_payload_info(HOSTADDRESS phys_addr, u64 offset, u32 bytes,
if (!info) {
rc = -CONTROLVM_RESP_ERROR_PAYLOAD_INVALID;
goto Away;
goto cleanup;
}
memset(info, 0, sizeof(struct controlvm_payload_info));
if ((offset == 0) || (bytes == 0)) {
rc = -CONTROLVM_RESP_ERROR_PAYLOAD_INVALID;
goto Away;
goto cleanup;
}
payload = ioremap_cache(phys_addr + offset, bytes);
if (!payload) {
rc = -CONTROLVM_RESP_ERROR_IOREMAP_FAILED;
goto Away;
goto cleanup;
}
info->offset = offset;
info->bytes = bytes;
info->ptr = payload;
Away:
cleanup:
if (rc < 0) {
if (payload != NULL) {
if (payload) {
iounmap(payload);
payload = NULL;
}