redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: comedi: ni_labpc: don't clear cmd3 bits explicitly in labpc_ai_cmd() 

`labpc_ai_cmd()` calls `labpc_cancel()` which already sets
`devpriv->cmd3` to 0.  Remove the lines from `labpc_ai_cmd()` that clear
specific bits in `devpriv->cmd3` explicitly as they have no effect.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Ian Abbott 2013-06-28 17:09:18 +01:00 committed by Greg Kroah-Hartman
parent 725a70d8a6
commit f12a34ca0b
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/comedi/drivers/ni_labpc.c
View File

@ -976,8 +976,7 @@ static int labpc_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
release_dma_lock(irq_flags);
/* enable board's dma */
devpriv->cmd3 |= (CMD3_DMAEN | CMD3_DMATCINTEN);
} else
devpriv->cmd3 &= ~(CMD3_DMAEN | CMD3_DMATCINTEN);
}
#endif
/* enable error interrupts */
@ -985,8 +984,6 @@ static int labpc_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
/* enable fifo not empty interrupt? */
if (xfer == fifo_not_empty_transfer)
devpriv->cmd3 |= CMD3_FIFOINTEN;
else
devpriv->cmd3 &= ~CMD3_FIFOINTEN;
devpriv->write_byte(devpriv->cmd3, dev->iobase + CMD3_REG);
/* setup any external triggering/pacing (cmd4 register) */