redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

usb: phy: phy-fsl-usb: Make structure fsl_otg_initdata constant 

Static structure fsl_otg_initdata, of type fsl_otg_config, is used only
once, when the value of its field otg_port is assigned to another
variable. As fsl_otg_initdata.otg_port is of type u8, any changes to
its copy do not affect the original, and fsl_otg_initdata itself is
never modified. Hence make fsl_otg_initdata constant to protect it from
unintended modification.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
alistair/sunxi64-5.4-dsi
Nishka Dasgupta 2019-08-19 13:12:34 +05:30 committed by Felipe Balbi
parent c33f141615
commit f1b19006f4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/phy/phy-fsl-usb.c
View File

@ -65,7 +65,7 @@ struct fsl_otg_timer *b_data_pulse_tmr, *b_vbus_pulse_tmr, *b_srp_fail_tmr,
static struct list_head active_timers;
static struct fsl_otg_config fsl_otg_initdata = {
static const struct fsl_otg_config fsl_otg_initdata = {
.otg_port = 1,
};