mmc: core: fix memory leak in mmc_add_host
led_trigger_register_simple() allocates memory which must not be leaked in the error-path of mmc_add_host. Move it past the only error-check in the function. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Chris Ball <cjb@laptop.org>
This commit is contained in:
parent
b177bc9188
commit
f317dfeb86
|
@ -324,12 +324,12 @@ int mmc_add_host(struct mmc_host *host)
|
||||||
WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) &&
|
WARN_ON((host->caps & MMC_CAP_SDIO_IRQ) &&
|
||||||
!host->ops->enable_sdio_irq);
|
!host->ops->enable_sdio_irq);
|
||||||
|
|
||||||
led_trigger_register_simple(dev_name(&host->class_dev), &host->led);
|
|
||||||
|
|
||||||
err = device_add(&host->class_dev);
|
err = device_add(&host->class_dev);
|
||||||
if (err)
|
if (err)
|
||||||
return err;
|
return err;
|
||||||
|
|
||||||
|
led_trigger_register_simple(dev_name(&host->class_dev), &host->led);
|
||||||
|
|
||||||
#ifdef CONFIG_DEBUG_FS
|
#ifdef CONFIG_DEBUG_FS
|
||||||
mmc_add_host_debugfs(host);
|
mmc_add_host_debugfs(host);
|
||||||
#endif
|
#endif
|
||||||
|
|
Loading…
Reference in a new issue