redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: topology: Fix a potential memory leak in 'soc_tplg_dapm_widget_denum_create()' 

If this sanity check fails, we must free the memory that has already been
allocated.

So we must go to 'err' as in the other error handling parth of this
function.

Fixes: 1a7dd6e2f1 ("ASoC: topology: Allow a widget to have multiple enum controls")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Christophe JAILLET 2017-09-14 22:44:24 +02:00 committed by Mark Brown
parent 6d5574ed5c
commit f3ee9096fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/soc/soc-topology.c
View File

@ -1301,7 +1301,7 @@ static struct snd_kcontrol_new *soc_tplg_dapm_widget_denum_create(
/* validate kcontrol */
if (strnlen(ec->hdr.name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) ==
SNDRV_CTL_ELEM_ID_NAME_MAXLEN)
return NULL;
goto err;
se = kzalloc(sizeof(*se), GFP_KERNEL);
if (se == NULL)