redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: ep93xx: fix incorrect array element size check 

Currently the while loop checks for the end of the array using
the size of egp->gc rather that the number of elements in the array,
so fix this. Also, perform the array size check first as stylistically
it is always good to bounds check on an array first before referencing
the array (in this case, we're just computing the address of an
element in an array so this is a moot point).

Fixes: fd935fc421 ("gpio: ep93xx: Do not pingpong irq numbers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
hifive-unleashed-5.1
Colin Ian King 2018-09-06 12:58:30 +01:00 committed by Linus Walleij
parent 02ad0437de
commit f40f73075c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-ep93xx.c
View File

@ -76,7 +76,7 @@ static int ep93xx_gpio_port(struct gpio_chip *gc)
struct ep93xx_gpio *epg = gpiochip_get_data(gc);
int port = 0;
while (gc != &epg->gc[port] && port < sizeof(epg->gc))
while (port < ARRAY_SIZE(epg->gc) && gc != &epg->gc[port])
port++;
/* This should not happen but is there as a last safeguard */