redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[PATCH] isdn/gigaset/common.c: fix a memory leak 

Fix a memory leak spotted by the Coverity checker if
(!try_module_get(owner)).

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
hifive-unleashed-5.1
Adrian Bunk 2006-04-10 22:55:19 -07:00 committed by Linus Torvalds
parent 8ca445df3a
commit f4675c7016
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/isdn/gigaset/common.c
View File

@ -1110,8 +1110,9 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors,
drv = kmalloc(sizeof *drv, GFP_KERNEL);
if (!drv)
return NULL;
if (!try_module_get(owner))
return NULL;
goto out1;
drv->cs = NULL;
drv->have_tty = 0;
@ -1125,10 +1126,11 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors,
drv->cs = kmalloc(minors * sizeof *drv->cs, GFP_KERNEL);
if (!drv->cs)
goto out1;
goto out2;
drv->flags = kmalloc(minors * sizeof *drv->flags, GFP_KERNEL);
if (!drv->flags)
goto out2;
goto out3;
for (i = 0; i < minors; ++i) {
drv->flags[i] = 0;
@ -1145,11 +1147,12 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors,
return drv;
out2:
out3:
kfree(drv->cs);
out2:
module_put(owner);
out1:
kfree(drv);
module_put(owner);
return NULL;
}
EXPORT_SYMBOL_GPL(gigaset_initdriver);