redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers: base: swnode: check if swnode is NULL before dereferencing it 

The to_software_mode() macro can potentially return NULL, so also add
a NULL check on swnode before dereferencing it to avoid any NULL
pointer dereferences.

Detected by CoverityScan, CID#1476052 ("Explicit null dereferenced")

Fixes: 59abd83672 (drivers: base: Introducing software nodes to the firmware node framework)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
hifive-unleashed-5.1
Colin Ian King 2018-12-22 12:43:33 +00:00 committed by Rafael J. Wysocki
parent 1d8f062ebc
commit f4747b9c68
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/base/swnode.c
View File

@ -477,7 +477,8 @@ software_node_get_parent(const struct fwnode_handle *fwnode)
{
struct software_node *swnode = to_software_node(fwnode);
return swnode->parent ? &swnode->parent->fwnode : NULL;
return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) :
NULL;
}
struct fwnode_handle *