apparmorfs: fix use-after-free on symlink traversal
symlink body shouldn't be freed without an RCU delay. Switch apparmorfs to ->destroy_inode() and use of call_rcu(); free both the inode and symlink body in the callback. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>hifive-unleashed-5.1
parent
46c8744196
commit
f51dcd0f62
|
@ -123,17 +123,22 @@ static int aafs_show_path(struct seq_file *seq, struct dentry *dentry)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static void aafs_evict_inode(struct inode *inode)
|
static void aafs_i_callback(struct rcu_head *head)
|
||||||
{
|
{
|
||||||
truncate_inode_pages_final(&inode->i_data);
|
struct inode *inode = container_of(head, struct inode, i_rcu);
|
||||||
clear_inode(inode);
|
|
||||||
if (S_ISLNK(inode->i_mode))
|
if (S_ISLNK(inode->i_mode))
|
||||||
kfree(inode->i_link);
|
kfree(inode->i_link);
|
||||||
|
free_inode_nonrcu(inode);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void aafs_destroy_inode(struct inode *inode)
|
||||||
|
{
|
||||||
|
call_rcu(&inode->i_rcu, aafs_i_callback);
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct super_operations aafs_super_ops = {
|
static const struct super_operations aafs_super_ops = {
|
||||||
.statfs = simple_statfs,
|
.statfs = simple_statfs,
|
||||||
.evict_inode = aafs_evict_inode,
|
.destroy_inode = aafs_destroy_inode,
|
||||||
.show_path = aafs_show_path,
|
.show_path = aafs_show_path,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue