redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

USB: usbtest.c: unsigned retval makes ctrl_out return 0 in case of error

Browse source 
In my quest to try and figure out why test 14 (control write) doesn't
work with my EZ-USB board, I noticed that sometimes testusb reported
no error even though the kernel log complained "byte 0 is 0 not 2" etc.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Orjan Friberg 2006-08-08 23:31:40 -07:00 committed by Greg Kroah-Hartman
parent 2011e9249a
commit f54fa84dda
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/usb/misc/usbtest.c
View file

@ -1242,11 +1242,12 @@ done:
static int ctrl_out (struct usbtest_dev *dev, static int ctrl_out (struct usbtest_dev *dev,
unsigned count, unsigned length, unsigned vary) unsigned count, unsigned length, unsigned vary)
{ {
unsigned i, j, len, retval; unsigned i, j, len;
int retval;
u8 *buf; u8 *buf;
char *what = "?"; char *what = "?";
struct usb_device *udev; struct usb_device *udev;
if (length < 1 || length > 0xffff || vary >= length) if (length < 1 || length > 0xffff || vary >= length)
return -EINVAL; return -EINVAL;