pinctrl: core: Remove extra kref_get which blocks hogs being freed
commit5.4-rM2-2.2.x-imx-squashedaafd56fc79
upstream. kref_init starts with the reference count at 1, which will be balanced by the pinctrl_put in pinctrl_unregister. The additional kref_get in pinctrl_claim_hogs will increase this count to 2 and cause the hogs to not get freed when pinctrl_unregister is called. Fixes:6118714275
("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()") Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://lore.kernel.org/r/20200228154142.13860-1-ckeepax@opensource.cirrus.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
d2df67d741
commit
f5ace0987a
|
@ -2025,7 +2025,6 @@ static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev)
|
|||
return PTR_ERR(pctldev->p);
|
||||
}
|
||||
|
||||
kref_get(&pctldev->p->users);
|
||||
pctldev->hog_default =
|
||||
pinctrl_lookup_state(pctldev->p, PINCTRL_STATE_DEFAULT);
|
||||
if (IS_ERR(pctldev->hog_default)) {
|
||||
|
|
Loading…
Reference in New Issue