redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: pm: add error handling to bundle activation 

The firmware now keeps the underlying hardware disabled until
receiving the first Bundle Activate request. Additionally: requesting
transition to a state the bundle is already in is no longer an error.

We can now add proper error handling to the bundle activate call.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Bartosz Golaszewski 2016-07-21 18:09:34 +02:00 committed by Greg Kroah-Hartman
parent 2358024b67
commit f5c93dea8f
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/greybus/core.c
View File

@ -181,12 +181,11 @@ static int greybus_probe(struct device *dev)
return retval;
}
/*
* FIXME: We need to perform error handling on bundle activate call
* below when firmware is ready. We just allow the activate operation to
* fail for now since bundle may be in active already.
*/
gb_control_bundle_activate(bundle->intf->control, bundle->id);
retval = gb_control_bundle_activate(bundle->intf->control, bundle->id);
if (retval) {
pm_runtime_put(&bundle->intf->dev);
return retval;
}
/*
* Unbound bundle devices are always deactivated. During probe, the