redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: dgap: Simplify to set a concentrator type

Browse source 
It is same manner with setting a board type.
For example of config file for concentrator,
    "conc ccon" or
    "conc epcon"

After allocating a type of "CNODE" then set a type of concentrator.
So remove cases in swith statement, just get a token from string
and set to "conc.type". And also it doesn't need to "conc.v_type".

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daeseok Youn 2014-08-09 14:38:41 +09:00 committed by Greg Kroah-Hartman
parent 77a4492fcc
commit f6aa0164cd
2 changed files with 7 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
drivers/staging/dgap/dgap.c
View file

@ -6387,6 +6387,7 @@ static int dgap_parsefile(char **in)
for (; ;) {
int board_type = 0;
int conc_type = 0;
rc = dgap_gettok(in);
if (rc == 0) {
@ -6719,24 +6720,15 @@ static int dgap_parsefile(char **in)
else
brd->u.board.conc1++;
break;
case CX: /* c/x type concentrator */
if (p->type != CNODE) {
dgap_err("cx only valid for concentrators");
conc_type = dgap_gettok(in);
if (conc_type == 0 || conc_type != CX ||
conc_type != EPC) {
dgap_err("failed to set a type of concentratros");
return -1;
}
p->u.conc.type = CX;
p->u.conc.v_type = 1;
break;
case EPC: /* epc type concentrator */
if (p->type != CNODE) {
dgap_err("cx only valid for concentrators");
return -1;
}
p->u.conc.type = EPC;
p->u.conc.v_type = 1;
p->u.conc.type = conc_type;
break;
case MOD: /* EBI module */
@ -7200,10 +7192,6 @@ static int dgap_checknode(struct cnode *p)
return 0;
case CNODE:
if (p->u.conc.v_type == 0) {
dgap_err("concentrator type not specified");
return 1;
}
if (p->u.conc.v_speed == 0) {
dgap_err("concentrator line speed not specified");
return 1;

1
drivers/staging/dgap/dgap.h
View file

@ -1206,7 +1206,6 @@ struct cnode {
char *id;
char *idstr;
long start;
char v_type;
char v_connect;
char v_speed;
char v_nport;