redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

rds: fix crash in rds_info_getsockopt() 

The conversion to pin_user_pages() had a bug: it overlooked
the case of allocation of pages failing. Fix that by restoring
an equivalent check.

Reported-by: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com
Fixes: dbfe7d7437 ("rds: convert get_user_pages() --> pin_user_pages()")

Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Cc: rds-devel@oss.oracle.com
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
alistair/sunxi64-5.8
John Hubbard 2020-05-20 12:41:47 -07:00 committed by David S. Miller
parent 4f65e2f483
commit f78cdbd75a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/rds/info.c
View File

@ -234,7 +234,8 @@ call_func:
ret = -EFAULT;
out:
unpin_user_pages(pages, nr_pages);
if (pages)
unpin_user_pages(pages, nr_pages);
kfree(pages);
return ret;