redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

KEYS: don't revoke uninstantiated key in request_key_auth_new() 

If key_instantiate_and_link() were to fail (which fortunately isn't
possible currently), the call to key_revoke(authkey) would crash with a
NULL pointer dereference in request_key_auth_revoke() because the key
has not yet been instantiated.

Fix this by removing the call to key_revoke().  key_put() is sufficient,
as it's not possible for an uninstantiated authkey to have been used for
anything yet.

Fixes: b5f545c880 ("[PATCH] keys: Permit running process to instantiate keys")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
hifive-unleashed-5.1
Eric Biggers 2017-09-21 13:57:41 -07:00 committed by David Howells
parent 44d8143340
commit f7b48cf08f
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
security/keys/request_key_auth.c
View File

@ -220,7 +220,6 @@ struct key *request_key_auth_new(struct key *target, const void *callout_info,
return authkey;
error_put_authkey:
key_revoke(authkey);
key_put(authkey);
error_free_rka:
free_request_key_auth(rka);