drivers/net/ethernet/ibm/emac/mal.c: use WARN
Use WARN rather than printk followed by WARN_ON(1), for conciseness. A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression list es; @@ -printk( +WARN(1, es); -WARN_ON(1); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
bb263e18f4
commit
f7c3f96a41
|
@ -738,13 +738,11 @@ static int __devexit mal_remove(struct platform_device *ofdev)
|
|||
/* Synchronize with scheduled polling */
|
||||
napi_disable(&mal->napi);
|
||||
|
||||
if (!list_empty(&mal->list)) {
|
||||
if (!list_empty(&mal->list))
|
||||
/* This is *very* bad */
|
||||
printk(KERN_EMERG
|
||||
WARN(1, KERN_EMERG
|
||||
"mal%d: commac list is not empty on remove!\n",
|
||||
mal->index);
|
||||
WARN_ON(1);
|
||||
}
|
||||
|
||||
dev_set_drvdata(&ofdev->dev, NULL);
|
||||
|
||||
|
|
Loading…
Reference in a new issue