1
0
Fork 0

bcache: fix cache_set_flush() NULL pointer dereference on OOM

When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup.  This appears to happen only
during an OOM condition on bcache_register.

Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: stable@vger.kernel.org
hifive-unleashed-5.1
Eric Wheeler 2016-03-07 15:17:50 -08:00 committed by Jens Axboe
parent 9b299728ed
commit f8b11260a4
1 changed files with 3 additions and 0 deletions

View File

@ -1373,6 +1373,9 @@ static void cache_set_flush(struct closure *cl)
struct btree *b;
unsigned i;
if (!c)
closure_return(cl);
bch_cache_accounting_destroy(&c->accounting);
kobject_put(&c->internal);