x86, mce, cmci: avoid potential reentry of threshold interrupt
Impact: minor bugfix The threshold handler on AMD (and soon on Intel) could be theoretically reentered by the hardware. This could lead to corrupted events because the machine check poll code assumes it is not reentered. Move the APIC ACK to the end of the interrupt handler to let the hardware avoid that. Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
This commit is contained in:
parent
b276268631
commit
f9695df42c
|
@ -15,10 +15,11 @@ void (*mce_threshold_vector)(void) = default_threshold_interrupt;
|
|||
|
||||
asmlinkage void mce_threshold_interrupt(void)
|
||||
{
|
||||
ack_APIC_irq();
|
||||
exit_idle();
|
||||
irq_enter();
|
||||
inc_irq_stat(irq_threshold_count);
|
||||
mce_threshold_vector();
|
||||
irq_exit();
|
||||
/* Ack only at the end to avoid potential reentry */
|
||||
ack_APIC_irq();
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue