redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

uas: Add response iu handling 

If something goes wrong in our communication with an uas device we may get
a response iu in reaction to a cmnd, rather then a status iu. In this case
propagate an error upwards, rather then logging a bogus iu message.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Hans de Goede 2014-09-13 12:26:51 +02:00 committed by Greg Kroah-Hartman
parent ce39fe6fa1
commit fac1f48584
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/usb/storage/uas.c
View File

@ -328,6 +328,16 @@ static void uas_stat_cmplt(struct urb *urb)
}
uas_xfer_data(urb, cmnd, SUBMIT_DATA_OUT_URB);
break;
case IU_ID_RESPONSE:
uas_log_cmd_state(cmnd, "unexpected response iu",
((struct response_iu *)iu)->response_code);
/* Error, cancel data transfers */
data_in_urb = usb_get_urb(cmdinfo->data_in_urb);
data_out_urb = usb_get_urb(cmdinfo->data_out_urb);
cmdinfo->state &= ~COMMAND_INFLIGHT;
cmnd->result = DID_ERROR << 16;
uas_try_complete(cmnd, __func__);
break;
default:
uas_log_cmd_state(cmnd, "bogus IU", iu->iu_id);
}