parisc: fix possible memory leak in pat_query_module()
pa_pdc_cell has been allocated in this function and so should be freed before leaving from the error handling cases. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Helge Deller <deller@gmx.de>hifive-unleashed-5.1
parent
ec758f9832
commit
fbd48433e7
|
@ -186,12 +186,14 @@ pat_query_module(ulong pcell_loc, ulong mod_index)
|
||||||
|
|
||||||
if (status != PDC_OK) {
|
if (status != PDC_OK) {
|
||||||
/* no more cell modules or error */
|
/* no more cell modules or error */
|
||||||
|
kfree(pa_pdc_cell);
|
||||||
return status;
|
return status;
|
||||||
}
|
}
|
||||||
|
|
||||||
temp = pa_pdc_cell->cba;
|
temp = pa_pdc_cell->cba;
|
||||||
dev = alloc_pa_dev(PAT_GET_CBA(temp), &(pa_pdc_cell->mod_path));
|
dev = alloc_pa_dev(PAT_GET_CBA(temp), &(pa_pdc_cell->mod_path));
|
||||||
if (!dev) {
|
if (!dev) {
|
||||||
|
kfree(pa_pdc_cell);
|
||||||
return PDC_OK;
|
return PDC_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue