redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB (11334): pvrusb2: Fix uninitialized tuner_setup field(s)

Browse source 
Any time a struct (especially one not defined by this driver) is
allocated, we MUST zero its underlying storage.  This makes our usage
of the struct predictable and robust against future changes where
fields might be added that we don't know about.  Failing to do this
with tuner_setup left the config field uninitialized which then caused
trouble with the tuner type used for HVR-1950 devices.

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mike Isely 2009-04-01 01:55:26 -03:00 committed by Mauro Carvalho Chehab
parent 7bf56f94a1
commit fcd62cf7f6
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/media/video/pvrusb2/pvrusb2-hdw.c
View file

@ -2926,6 +2926,7 @@ static void pvr2_subdev_update(struct pvr2_hdw *hdw)
pvr2_trace(PVR2_TRACE_CHIPS, "subdev tuner set_type(%d)", pvr2_trace(PVR2_TRACE_CHIPS, "subdev tuner set_type(%d)",
hdw->tuner_type); hdw->tuner_type);
if (((int)(hdw->tuner_type)) >= 0) { if (((int)(hdw->tuner_type)) >= 0) {
memset(&setup, 0, sizeof(setup));
setup.addr = ADDR_UNSET; setup.addr = ADDR_UNSET;
setup.type = hdw->tuner_type; setup.type = hdw->tuner_type;
setup.mode_mask = T_RADIO | T_ANALOG_TV; setup.mode_mask = T_RADIO | T_ANALOG_TV;