redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ntb_netdev: Fix list_for_each_entry exit issue 

If list_for_each_entry exits without finding the ntb_device, the dev
pointer will not be NULL.  Thus the check will never be true and the
code will not exit when it should.  Correct this by adding a bool to
determine when the device is found, otherwise exit in good fashion.

Signed-off-by: Jon Mason <jon.mason@intel.com>
hifive-unleashed-5.1
Jon Mason 2013-11-22 16:44:13 -07:00
parent 455c6fdbd2
commit fea903ecd7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ntb_netdev.c
View File

@ -367,12 +367,15 @@ static void ntb_netdev_remove(struct pci_dev *pdev)
{
struct net_device *ndev;
struct ntb_netdev *dev;
bool found = false;
list_for_each_entry(dev, &dev_list, list) {
if (dev->pdev == pdev)
if (dev->pdev == pdev) {
found = true;
break;
}
}
if (dev == NULL)
if (!found)
return;
list_del(&dev->list);