redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

clk: fractional-divider: cast parent_rate to u64 before multiplying 

On 32bit architectures, like ARM calculating the fractional rate will
do the multiplication before converting the value to u64 when it gets
assigned to ret, which can produce overflows.

The error in question happened with a parent_rate of 386MHz, m = 3000,
n = 60000, which resulted in a wrong rate value of 15812Hz.

Therefore cast parent_rate to u64 to make sure the multiplication
happens in a 64bit space and produces the correct 192MHz in the example.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
hifive-unleashed-5.1
Heiko Stübner 2014-08-28 12:46:10 +02:00 committed by Mike Turquette
parent f82a1d1586
commit feaefa0ea1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/clk/clk-fractional-divider.c
View File

@ -36,7 +36,7 @@ static unsigned long clk_fd_recalc_rate(struct clk_hw *hw,
m = (val & fd->mmask) >> fd->mshift;
n = (val & fd->nmask) >> fd->nshift;
ret = parent_rate * m;
ret = (u64)parent_rate * m;
do_div(ret, n);
return ret;