redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

PCI: Remove duplicate check for positive return value from probe() functions

Browse source 
Function __pci_device_probe() tries to be careful about a PCI driver
probe() hook returning a positive value, but this is not really necessary,
since the same fix up is already done in local_pci_probe() (preceded by a
noisy warning), which renders this instance dead code.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
This commit is contained in:
Gabriel Krisman Bertazi 2017-02-06 13:34:14 -02:00 committed by Bjorn Helgaas
parent 60db3a4d8c
commit fed678145d
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/pci/pci-driver.c
View file

@ -381,8 +381,6 @@ static int __pci_device_probe(struct pci_driver *drv, struct pci_dev *pci_dev)
id = pci_match_device(drv, pci_dev); id = pci_match_device(drv, pci_dev);
if (id) if (id)
error = pci_call_probe(drv, pci_dev, id); error = pci_call_probe(drv, pci_dev, id);
if (error >= 0)
error = 0;
} }
return error; return error;
} }