1
0
Fork 0
alistair23-linux/drivers/slimbus
Zhang Changzhong 428bb00114 slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()
platform_get_resource_byname() may fail and in this case a NULL
dereference will occur.

Fix it to use devm_platform_ioremap_resource_byname() instead of calling
platform_get_resource_byname() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t,
n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: ad7fcbc308 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607392473-20610-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-10 16:23:56 +01:00
..
Kconfig slimbus: qcom-ngd-ctrl: fix SSR dependencies 2020-12-09 19:57:03 +01:00
Makefile slimbus: stream: add stream support 2018-07-07 17:25:23 +02:00
core.c slimbus: core: do not enter to clock pause mode in core 2020-09-25 14:41:50 +02:00
messaging.c slimbus: messaging: Fix fall-through warnings for Clang 2020-11-27 16:03:43 +01:00
qcom-ctrl.c slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew() 2020-12-10 16:23:56 +01:00
qcom-ngd-ctrl.c slimbus: qcom-ngd-ctrl: remove redundant out of memory messages 2020-11-27 16:03:43 +01:00
sched.c slimbus: Add support for 'clock-pause' feature 2017-12-19 11:01:03 +01:00
slimbus.h slimbus: fix a kernel-doc markup 2020-11-27 16:03:42 +01:00
stream.c slimbus: fix kerneldoc comments 2019-06-10 18:44:21 +02:00