1
0
Fork 0
alistair23-linux/drivers/gpu/drm/gma500
Tom Rix 37028b8bc5 drm/gma500: fix double free of gma_connector
[ Upstream commit 4e19d51ca5 ]

clang static analysis reports this problem:

cdv_intel_dp.c:2101:2: warning: Attempt to free released memory
        kfree(gma_connector);
        ^~~~~~~~~~~~~~~~~~~~

In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off()
fails, the handler calls cdv_intel_dp_destroy(connector) which does
the first free of gma_connector. So adjust the goto label and skip
the second free.

Fixes: d112a8163f ("gma500/cdv: Add eDP support")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201003193928.18869-1-trix@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-30 11:51:00 +01:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
accel_2d.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
backlight.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
blitter.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
blitter.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_device.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_intel_crt.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
cdv_intel_display.c gma/gma500: fix a memory disclosure bug due to uninitialized bytes 2020-10-01 13:17:13 +02:00
cdv_intel_dp.c drm/gma500: fix double free of gma_connector 2020-12-30 11:51:00 +01:00
cdv_intel_hdmi.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
cdv_intel_lvds.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
framebuffer.c drm/gma500: Fixup fbdev stolen size usage evaluation 2020-02-24 08:36:22 +01:00
framebuffer.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gem.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gem.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
gma_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gma_device.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gma_display.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gma_display.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gtt.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gtt.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
intel_bios.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
intel_bios.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
intel_gmbus.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
intel_i2c.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mdfld_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mdfld_dsi_dpi.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
mdfld_dsi_dpi.h drm: Make the .mode_fixup() operations mode argument a const pointer 2012-07-19 21:52:38 -04:00
mdfld_dsi_output.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
mdfld_dsi_output.h drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
mdfld_dsi_pkg_sender.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
mdfld_dsi_pkg_sender.h drm/gma500: mdfld: Reuse video/mipi_display.h 2014-11-13 10:44:41 +01:00
mdfld_intel_display.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mdfld_output.c
mdfld_output.h
mdfld_tmd_vid.c drm/gma500: drop drmP.h from header files 2019-05-22 14:13:33 +02:00
mdfld_tpo_vid.c gpu: drm: gma500: remove two more dead variable 2017-05-23 17:38:33 +02:00
mid_bios.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mid_bios.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mmu.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mmu.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
oaktrail.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
oaktrail_crtc.c drm/gma500: fix memory disclosures due to uninitialized bytes 2019-12-31 16:44:13 +01:00
oaktrail_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
oaktrail_hdmi.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
oaktrail_hdmi_i2c.c tree-wide: use reinit_completion instead of INIT_COMPLETION 2013-11-15 09:32:21 +09:00
oaktrail_lvds.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
oaktrail_lvds_i2c.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
opregion.c drm/gma500: remove unnecessary config_enabled() guard 2016-08-24 07:43:42 +02:00
opregion.h gma500: move the ASLE enable 2012-07-16 09:20:33 -07:00
power.c drm/gma500: use to_pci_dev() 2016-01-04 07:57:38 +01:00
power.h drm/gma500: drop drmP.h from header files 2019-05-22 14:13:33 +02:00
psb_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_device.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
psb_drv.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_drv.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_intel_display.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_intel_drv.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
psb_intel_lvds.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_intel_modes.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_intel_reg.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
psb_intel_sdvo.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
psb_intel_sdvo_regs.h
psb_irq.c drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[] 2020-11-18 19:20:31 +01:00
psb_irq.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_lid.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_reg.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
tc35876x-dsi-lvds.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
tc35876x-dsi-lvds.h