Jonathan Cameron 66b8b8f75e iio:proximity:mb1232: Fix timestamp alignment and prevent data leak. ... commit f60e8bb842 upstream. One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses a 16 byte s16 array on the stack As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data with alignment ensured by use of an explicit c structure. This data is allocated with kzalloc so no data can leak appart from previous readings. In this case the forced alignment of the ts is necessary to ensure correct padding on x86_32 where the s64 would only be 4 byte aligned. Fixes: 16b0526153 ("mb1232.c: add distance iio sensor with i2c") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Cc: Andreas Klinger <ak@it-klinger.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: <Stable@vger.kernel.org> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-09-17 13:47:50 +02:00
..
Kconfig	Kconfig: Fix the reference to the RFD77402 ToF sensor in the 'help' section	2019-08-25 19:08:36 +01:00
Makefile	mb1232.c: add distance iio sensor with i2c	2019-04-04 20:20:17 +01:00
as3935.c	iio: proximity: as3935: fix use-after-free on device remove	2019-04-04 20:19:56 +01:00
isl29501.c	iio: light: isl29501: Simplify code to kill compiler warning	2018-09-02 09:56:49 +01:00
mb1232.c	iio:proximity:mb1232: Fix timestamp alignment and prevent data leak.	2020-09-17 13:47:50 +02:00
pulsedlight-lidar-lite-v2.c	iio: add SPDX identifier for various drivers	2018-02-18 11:55:19 +00:00
rfd77402.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 330	2019-06-05 17:37:06 +02:00
srf04.c	iio: srf04: fix wrong limitation in distance measuring	2019-10-12 14:31:09 +01:00
srf08.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 330	2019-06-05 17:37:06 +02:00
sx9500.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
vl53l0x-i2c.c	iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor.	2018-09-22 16:42:56 +01:00