Amir Goldstein f27ad513a4 fanotify: fix ignore mask logic for events on child and on dir ... [ Upstream commit 2f02fd3fa1 ] The comments in fanotify_group_event_mask() say: "If the event is on dir/child and this mark doesn't care about events on dir/child, don't send it!" Specifically, mount and filesystem marks do not care about events on child, but they can still specify an ignore mask for those events. For example, a group that has: - A mount mark with mask 0 and ignore_mask FAN_OPEN - An inode mark on a directory with mask FAN_OPEN | FAN_OPEN_EXEC with flag FAN_EVENT_ON_CHILD A child file open for exec would be reported to group with the FAN_OPEN event despite the fact that FAN_OPEN is in ignore mask of mount mark, because the mark iteration loop skips over non-inode marks for events on child when calculating the ignore mask. Move ignore mask calculation to the top of the iteration loop block before excluding marks for events on dir/child. Link: https://lore.kernel.org/r/20200524072441.18258-1-amir73il@gmail.com Reported-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/linux-fsdevel/20200521162443.GA26052@quack2.suse.cz/ Fixes: 55bf882c7f "fanotify: fix merging marks masks with FAN_ONDIR" Fixes: b469e7e47c "fanotify: fix handling of events on child..." Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-06-17 16:40:24 +02:00
..
dnotify	selinux/stable-5.4 PR 20190917	2019-09-23 11:21:04 -07:00
fanotify	fanotify: fix ignore mask logic for events on child and on dir	2020-06-17 16:40:24 +02:00
inotify	fsnotify: replace inode pointer with an object id	2020-05-14 07:58:30 +02:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fdinfo.c	fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()	2018-11-15 17:34:27 +01:00
fdinfo.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fsnotify.c	fs: call fsnotify_sb_delete after evict_inodes	2020-01-12 12:21:38 +01:00
fsnotify.h	notify: export symbols for use by the knfsd file cache	2019-08-19 11:00:39 -04:00
group.c	notify: export symbols for use by the knfsd file cache	2019-08-19 11:00:39 -04:00
mark.c	notify: export symbols for use by the knfsd file cache	2019-08-19 11:00:39 -04:00
notification.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00