Hoang Le 56e8947bcf tipc: fix NULL deref in tipc_link_xmit() ... [ Upstream commit b774134464 ] The buffer list can have zero skb as following path: tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so we need to check the list before casting an &sk_buff. Fault report: [] tipc: Bulk publication failure [] general protection fault, probably for non-canonical [#1] PREEMPT [...] [] KASAN: null-ptr-deref in range [0x00000000000000c8-0x00000000000000cf] [] CPU: 0 PID: 0 Comm: swapper/0 Kdump: loaded Not tainted 5.10.0-rc4+ #2 [] Hardware name: Bochs ..., BIOS Bochs 01/01/2011 [] RIP: 0010:tipc_link_xmit+0xc1/0x2180 [] Code: 24 b8 00 00 00 00 4d 39 ec 4c 0f 44 e8 e8 d7 0a 10 f9 48 [...] [] RSP: 0018:ffffc90000006ea0 EFLAGS: 00010202 [] RAX: dffffc0000000000 RBX: ffff8880224da000 RCX: 1ffff11003d3cc0d [] RDX: 0000000000000019 RSI: ffffffff886007b9 RDI: 00000000000000c8 [] RBP: ffffc90000007018 R08: 0000000000000001 R09: fffff52000000ded [] R10: 0000000000000003 R11: fffff52000000dec R12: ffffc90000007148 [] R13: 0000000000000000 R14: 0000000000000000 R15: ffffc90000007018 [] FS: 0000000000000000(0000) GS:ffff888037400000(0000) knlGS:000[...] [] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [] CR2: 00007fffd2db5000 CR3: 000000002b08f000 CR4: 00000000000006f0 Fixes: af9b028e27 ("tipc: make media xmit call outside node spinlock context") Acked-by: Jon Maloy <jmaloy@redhat.com> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au> Link: https://lore.kernel.org/r/20210108071337.3598-1-hoang.h.le@dektech.com.au Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-23 15:58:00 +01:00
..
Kconfig	docs: kbuild: convert docs to ReST and rename to *.rst	2019-06-14 14:21:21 -06:00
Makefile	tipc: enable tracepoints in tipc	2018-12-19 11:49:24 -08:00
addr.c	tipc: initialise addr_trail_end when setting node addresses	2019-08-11 21:40:04 -07:00
addr.h	tipc: add 128-bit node identifier	2018-03-23 13:12:18 -04:00
bcast.c	tipc: fix potential hanging after b/rcast changing	2020-01-23 08:22:44 +01:00
bcast.h	tipc: fix a null pointer deref	2019-03-21 09:56:55 -07:00
bearer.c	tipc: add loopback device tracking	2019-08-08 22:11:39 -07:00
bearer.h	tipc: add loopback device tracking	2019-08-08 22:11:39 -07:00
core.c	tipc: fix a deadlock when flushing scheduled work	2020-12-11 13:23:32 +01:00
core.h	tipc: fix a deadlock when flushing scheduled work	2020-12-11 13:23:32 +01:00
diag.c	tipc: switch to rhashtable iterator	2018-08-29 18:04:54 -07:00
discover.c	tipc: fix lockdep warning when reinitilaizing sockets	2018-11-17 22:01:31 -08:00
discover.h	tipc: some cleanups in the file discover.c	2018-03-23 13:12:17 -04:00
eth_media.c	tipc: make media address offset a common define	2015-02-27 18:18:48 -05:00
group.c	tipc: Fix memory leak in tipc_group_create_member()	2020-09-26 18:03:13 +02:00
group.h	tipc: extend sock diag for group communication	2018-06-30 21:05:42 +09:00
ib_media.c	tipc: rename media/msg related definitions	2015-02-27 18:18:48 -05:00
link.c	tipc: fix NULL deref in tipc_link_xmit()	2021-01-23 15:58:00 +01:00
link.h	tipc: fix missing Name entries due to half-failover	2019-05-04 00:59:51 -04:00
monitor.c	tipc: update mon's self addr when node addr generated	2020-01-26 10:01:00 +01:00
monitor.h	tipc: update mon's self addr when node addr generated	2020-01-26 10:01:00 +01:00
msg.c	tipc: fix memory leak caused by tipc_buf_append()	2020-11-01 12:01:04 +01:00
msg.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-08-19 11:54:03 -07:00
name_distr.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-15 14:17:27 +02:00
name_distr.h	tipc: permit overlapping service ranges in name table	2018-03-31 22:19:52 -04:00
name_table.c	netlink: make nla_nest_start() add NLA_F_NESTED flag	2019-04-27 17:03:44 -04:00
name_table.h	tipc: eliminate message disordering during binding table update	2018-10-22 19:29:12 -07:00
net.c	tipc: fix a deadlock when flushing scheduled work	2020-12-11 13:23:32 +01:00
net.h	tipc: fix a deadlock when flushing scheduled work	2020-12-11 13:23:32 +01:00
netlink.c	tipc: add missing attribute validation for MTU property	2020-03-18 07:17:45 +01:00
netlink.h	tipc: make cluster size threshold for monitoring configurable	2016-07-26 14:26:42 -07:00
netlink_compat.c	tipc: fix uninit skb->data in tipc_nl_compat_dumpit()	2020-09-03 11:26:40 +02:00
node.c	tipc: clean up skb list lock handling on send path	2019-08-18 14:01:07 -07:00
node.h	tipc: optimize link synching mechanism	2019-07-25 15:55:47 -07:00
socket.c	tipc: fix link overflow issue at socket shutdown	2020-10-01 13:17:24 +02:00
socket.h	tipc: add trace_events for tipc socket	2018-12-19 11:49:24 -08:00
subscr.c	tipc: fix unbalanced reference counter	2018-04-12 21:46:10 -04:00
subscr.h	tipc: fix modprobe tipc failed after switch order of device registration	2019-05-20 10:45:43 -07:00
sysctl.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
topsrv.c	tipc: fix memory leak in tipc_topsrv_start()	2020-11-18 19:20:33 +01:00
topsrv.h	tipc: rename tipc_server to tipc_topsrv	2018-02-16 15:26:34 -05:00
trace.c	tipc: remove unneeded semicolon in trace.c	2019-01-17 22:04:43 -08:00
trace.h	tipc: add trace_events for tipc bearer	2018-12-19 11:49:25 -08:00
udp_media.c	tipc: block BH before using dst_cache	2020-06-03 08:21:03 +02:00
udp_media.h	tipc: implement configuration of UDP media MTU	2018-04-20 11:04:05 -04:00