1
0
Fork 0
alistair23-linux/sound/firewire/tascam
Geert Uytterhoeven 548e4168e6 ALSA: firewire-tascam: Fix integer overflow in midi_port_work()
commit 9f65df9c58 upstream.

As snd_fw_async_midi_port.consume_bytes is unsigned int, and
NSEC_PER_SEC is 1000000000L, the second multiplication in

    port->consume_bytes * 8 * NSEC_PER_SEC / 31250

always overflows on 32-bit platforms, truncating the result.  Fix this
by precalculating "NSEC_PER_SEC / 31250", which is an integer constant.

Note that this assumes port->consume_bytes <= 16777.

Fixes: 531f471834 ("ALSA: firewire-lib/firewire-tascam: localize async midi port")
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20210111130251.361335-3-geert+renesas@glider.be
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-19 18:26:19 +01:00
..
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
amdtp-tascam.c ALSA: firewire-tascam: fix corruption due to spin lock without restoration in SoftIRQ context 2020-01-23 08:22:31 +01:00
tascam-hwdep.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
tascam-midi.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
tascam-pcm.c ALSA: firewire-tascam: handle error code when getting current source of clock 2019-09-10 16:16:00 +02:00
tascam-proc.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
tascam-stream.c Merge branch 'for-next' into for-linus 2019-09-14 17:26:10 +02:00
tascam-transaction.c ALSA: firewire-tascam: Fix integer overflow in midi_port_work() 2021-01-19 18:26:19 +01:00
tascam.c ALSA; firewire-tascam: exclude Tascam FE-8 from detection 2020-09-09 19:12:33 +02:00
tascam.h ALSA: firewire-tascam: add note for FE-8 2019-09-06 14:59:43 +02:00