![David Howells](/assets/img/avatar_default.png)
rxrpc calls shouldn't hold refs on the sock struct. This was done so that the socket wouldn't go away whilst the call was in progress, such that the call could reach the socket's queues. However, we can mark the socket as requiring an RCU release and rely on the RCU read lock. To make this work, we do: (1) rxrpc_release_call() removes the call's call user ID. This is now only called from socket operations and not from the call processor: rxrpc_accept_call() / rxrpc_kernel_accept_call() rxrpc_reject_call() / rxrpc_kernel_reject_call() rxrpc_kernel_end_call() rxrpc_release_calls_on_socket() rxrpc_recvmsg() Though it is also called in the cleanup path of rxrpc_accept_incoming_call() before we assign a user ID. (2) Pass the socket pointer into rxrpc_release_call() rather than getting it from the call so that we can get rid of uninitialised calls. (3) Fix call processor queueing to pass a ref to the work queue and to release that ref at the end of the processor function (or to pass it back to the work queue if we have to requeue). (4) Skip out of the call processor function asap if the call is complete and don't requeue it if the call is complete. (5) Clean up the call immediately that the refcount reaches 0 rather than trying to defer it. Actual deallocation is deferred to RCU, however. (6) Don't hold socket refs for allocated calls. (7) Use the RCU read lock when queueing a message on a socket and treat the call's socket pointer according to RCU rules and check it for NULL. We also need to use the RCU read lock when viewing a call through procfs. (8) Transmit the final ACK/ABORT to a client call in rxrpc_release_call() if this hasn't been done yet so that we can then disconnect the call. Once the call is disconnected, it won't have any access to the connection struct and the UDP socket for the call work processor to be able to send the ACK. Terminal retransmission will be handled by the connection processor. (9) Release all calls immediately on the closing of a socket rather than trying to defer this. Incomplete calls will be aborted. The call refcount model is much simplified. Refs are held on the call by: (1) A socket's user ID tree. (2) A socket's incoming call secureq and acceptq. (3) A kernel service that has a call in progress. (4) A queued call work processor. We have to take care to put any call that we failed to queue. (5) sk_buffs on a socket's receive queue. A future patch will get rid of this. Whilst we're at it, we can do: (1) Get rid of the RXRPC_CALL_EV_RELEASE event. Release is now done entirely from the socket routines and never from the call's processor. (2) Get rid of the RXRPC_CALL_DEAD state. Calls now end in the RXRPC_CALL_COMPLETE state. (3) Get rid of the rxrpc_call::destroyer work item. Calls are now torn down when their refcount reaches 0 and then handed over to RCU for final cleanup. (4) Get rid of the rxrpc_call::deadspan timer. Calls are cleaned up immediately they're finished with and don't hang around. Post-completion retransmission is handled by the connection processor once the call is disconnected. (5) Get rid of the dead call expiry setting as there's no longer a timer to set. (6) rxrpc_destroy_all_calls() can just check that the call list is empty. Signed-off-by: David Howells <dhowells@redhat.com>
236 lines
5.8 KiB
C
236 lines
5.8 KiB
C
/* RxRPC packet transmission
|
|
*
|
|
* Copyright (C) 2007 Red Hat, Inc. All Rights Reserved.
|
|
* Written by David Howells (dhowells@redhat.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/net.h>
|
|
#include <linux/gfp.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/export.h>
|
|
#include <net/sock.h>
|
|
#include <net/af_rxrpc.h>
|
|
#include "ar-internal.h"
|
|
|
|
struct rxrpc_pkt_buffer {
|
|
struct rxrpc_wire_header whdr;
|
|
union {
|
|
struct {
|
|
struct rxrpc_ackpacket ack;
|
|
u8 acks[255];
|
|
u8 pad[3];
|
|
};
|
|
__be32 abort_code;
|
|
};
|
|
struct rxrpc_ackinfo ackinfo;
|
|
};
|
|
|
|
/*
|
|
* Fill out an ACK packet.
|
|
*/
|
|
static size_t rxrpc_fill_out_ack(struct rxrpc_call *call,
|
|
struct rxrpc_pkt_buffer *pkt)
|
|
{
|
|
u32 mtu, jmax;
|
|
u8 *ackp = pkt->acks;
|
|
|
|
pkt->ack.bufferSpace = htons(8);
|
|
pkt->ack.maxSkew = htons(0);
|
|
pkt->ack.firstPacket = htonl(call->rx_data_eaten + 1);
|
|
pkt->ack.previousPacket = htonl(call->ackr_prev_seq);
|
|
pkt->ack.serial = htonl(call->ackr_serial);
|
|
pkt->ack.reason = RXRPC_ACK_IDLE;
|
|
pkt->ack.nAcks = 0;
|
|
|
|
mtu = call->peer->if_mtu;
|
|
mtu -= call->peer->hdrsize;
|
|
jmax = rxrpc_rx_jumbo_max;
|
|
pkt->ackinfo.rxMTU = htonl(rxrpc_rx_mtu);
|
|
pkt->ackinfo.maxMTU = htonl(mtu);
|
|
pkt->ackinfo.rwind = htonl(rxrpc_rx_window_size);
|
|
pkt->ackinfo.jumbo_max = htonl(jmax);
|
|
|
|
*ackp++ = 0;
|
|
*ackp++ = 0;
|
|
*ackp++ = 0;
|
|
return 3;
|
|
}
|
|
|
|
/*
|
|
* Send a final ACK or ABORT call packet.
|
|
*/
|
|
int rxrpc_send_call_packet(struct rxrpc_call *call, u8 type)
|
|
{
|
|
struct rxrpc_connection *conn = NULL;
|
|
struct rxrpc_pkt_buffer *pkt;
|
|
struct msghdr msg;
|
|
struct kvec iov[2];
|
|
rxrpc_serial_t serial;
|
|
size_t len, n;
|
|
int ioc, ret;
|
|
u32 abort_code;
|
|
|
|
_enter("%u,%s", call->debug_id, rxrpc_pkts[type]);
|
|
|
|
spin_lock_bh(&call->lock);
|
|
if (call->conn)
|
|
conn = rxrpc_get_connection_maybe(call->conn);
|
|
spin_unlock_bh(&call->lock);
|
|
if (!conn)
|
|
return -ECONNRESET;
|
|
|
|
pkt = kzalloc(sizeof(*pkt), GFP_KERNEL);
|
|
if (!pkt) {
|
|
rxrpc_put_connection(conn);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
serial = atomic_inc_return(&conn->serial);
|
|
|
|
msg.msg_name = &call->peer->srx.transport;
|
|
msg.msg_namelen = call->peer->srx.transport_len;
|
|
msg.msg_control = NULL;
|
|
msg.msg_controllen = 0;
|
|
msg.msg_flags = 0;
|
|
|
|
pkt->whdr.epoch = htonl(conn->proto.epoch);
|
|
pkt->whdr.cid = htonl(call->cid);
|
|
pkt->whdr.callNumber = htonl(call->call_id);
|
|
pkt->whdr.seq = 0;
|
|
pkt->whdr.serial = htonl(serial);
|
|
pkt->whdr.type = type;
|
|
pkt->whdr.flags = conn->out_clientflag;
|
|
pkt->whdr.userStatus = 0;
|
|
pkt->whdr.securityIndex = call->security_ix;
|
|
pkt->whdr._rsvd = 0;
|
|
pkt->whdr.serviceId = htons(call->service_id);
|
|
|
|
iov[0].iov_base = pkt;
|
|
iov[0].iov_len = sizeof(pkt->whdr);
|
|
len = sizeof(pkt->whdr);
|
|
|
|
switch (type) {
|
|
case RXRPC_PACKET_TYPE_ACK:
|
|
spin_lock_bh(&call->lock);
|
|
n = rxrpc_fill_out_ack(call, pkt);
|
|
call->ackr_reason = 0;
|
|
|
|
spin_unlock_bh(&call->lock);
|
|
|
|
_proto("Tx ACK %%%u { m=%hu f=#%u p=#%u s=%%%u r=%s n=%u }",
|
|
serial,
|
|
ntohs(pkt->ack.maxSkew),
|
|
ntohl(pkt->ack.firstPacket),
|
|
ntohl(pkt->ack.previousPacket),
|
|
ntohl(pkt->ack.serial),
|
|
rxrpc_acks(pkt->ack.reason),
|
|
pkt->ack.nAcks);
|
|
|
|
iov[0].iov_len += sizeof(pkt->ack) + n;
|
|
iov[1].iov_base = &pkt->ackinfo;
|
|
iov[1].iov_len = sizeof(pkt->ackinfo);
|
|
len += sizeof(pkt->ack) + n + sizeof(pkt->ackinfo);
|
|
ioc = 2;
|
|
break;
|
|
|
|
case RXRPC_PACKET_TYPE_ABORT:
|
|
abort_code = call->abort_code;
|
|
pkt->abort_code = htonl(abort_code);
|
|
_proto("Tx ABORT %%%u { %d }", serial, abort_code);
|
|
iov[0].iov_len += sizeof(pkt->abort_code);
|
|
len += sizeof(pkt->abort_code);
|
|
ioc = 1;
|
|
break;
|
|
|
|
default:
|
|
BUG();
|
|
ret = -ENOANO;
|
|
goto out;
|
|
}
|
|
|
|
ret = kernel_sendmsg(conn->params.local->socket,
|
|
&msg, iov, ioc, len);
|
|
|
|
out:
|
|
rxrpc_put_connection(conn);
|
|
kfree(pkt);
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* send a packet through the transport endpoint
|
|
*/
|
|
int rxrpc_send_data_packet(struct rxrpc_connection *conn, struct sk_buff *skb)
|
|
{
|
|
struct kvec iov[1];
|
|
struct msghdr msg;
|
|
int ret, opt;
|
|
|
|
_enter(",{%d}", skb->len);
|
|
|
|
iov[0].iov_base = skb->head;
|
|
iov[0].iov_len = skb->len;
|
|
|
|
msg.msg_name = &conn->params.peer->srx.transport;
|
|
msg.msg_namelen = conn->params.peer->srx.transport_len;
|
|
msg.msg_control = NULL;
|
|
msg.msg_controllen = 0;
|
|
msg.msg_flags = 0;
|
|
|
|
/* send the packet with the don't fragment bit set if we currently
|
|
* think it's small enough */
|
|
if (skb->len - sizeof(struct rxrpc_wire_header) < conn->params.peer->maxdata) {
|
|
down_read(&conn->params.local->defrag_sem);
|
|
/* send the packet by UDP
|
|
* - returns -EMSGSIZE if UDP would have to fragment the packet
|
|
* to go out of the interface
|
|
* - in which case, we'll have processed the ICMP error
|
|
* message and update the peer record
|
|
*/
|
|
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 1,
|
|
iov[0].iov_len);
|
|
|
|
up_read(&conn->params.local->defrag_sem);
|
|
if (ret == -EMSGSIZE)
|
|
goto send_fragmentable;
|
|
|
|
_leave(" = %d [%u]", ret, conn->params.peer->maxdata);
|
|
return ret;
|
|
}
|
|
|
|
send_fragmentable:
|
|
/* attempt to send this message with fragmentation enabled */
|
|
_debug("send fragment");
|
|
|
|
down_write(&conn->params.local->defrag_sem);
|
|
|
|
switch (conn->params.local->srx.transport.family) {
|
|
case AF_INET:
|
|
opt = IP_PMTUDISC_DONT;
|
|
ret = kernel_setsockopt(conn->params.local->socket,
|
|
SOL_IP, IP_MTU_DISCOVER,
|
|
(char *)&opt, sizeof(opt));
|
|
if (ret == 0) {
|
|
ret = kernel_sendmsg(conn->params.local->socket, &msg, iov, 1,
|
|
iov[0].iov_len);
|
|
|
|
opt = IP_PMTUDISC_DO;
|
|
kernel_setsockopt(conn->params.local->socket, SOL_IP,
|
|
IP_MTU_DISCOVER,
|
|
(char *)&opt, sizeof(opt));
|
|
}
|
|
break;
|
|
}
|
|
|
|
up_write(&conn->params.local->defrag_sem);
|
|
_leave(" = %d [frag %u]", ret, conn->params.peer->maxdata);
|
|
return ret;
|
|
}
|