![Johan Hedberg](/assets/img/avatar_default.png)
Since Add/Remove Device perform the page scan updates independently from the HCI command completion we've introduced a potential race when multiple mgmt commands are queued. Doing the page scan updates through the req_workqueue ensures that the state changes are performed in a race-free manner. At the same time, to make the request helper more widely usable, extend it to also cover Inquiry Scan changes since those are behind the same HCI command. This is also reflected in the new name of the API as well as the work struct name. Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
85 lines
3.2 KiB
C
85 lines
3.2 KiB
C
/*
|
|
BlueZ - Bluetooth protocol stack for Linux
|
|
Copyright (C) 2014 Intel Corporation
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License version 2 as
|
|
published by the Free Software Foundation;
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY RIGHTS.
|
|
IN NO EVENT SHALL THE COPYRIGHT HOLDER(S) AND AUTHOR(S) BE LIABLE FOR ANY
|
|
CLAIM, OR ANY SPECIAL INDIRECT OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
ALL LIABILITY, INCLUDING LIABILITY FOR INFRINGEMENT OF ANY PATENTS,
|
|
COPYRIGHTS, TRADEMARKS OR OTHER RIGHTS, RELATING TO USE OF THIS
|
|
SOFTWARE IS DISCLAIMED.
|
|
*/
|
|
|
|
#define hci_req_sync_lock(hdev) mutex_lock(&hdev->req_lock)
|
|
#define hci_req_sync_unlock(hdev) mutex_unlock(&hdev->req_lock)
|
|
|
|
struct hci_request {
|
|
struct hci_dev *hdev;
|
|
struct sk_buff_head cmd_q;
|
|
|
|
/* If something goes wrong when building the HCI request, the error
|
|
* value is stored in this field.
|
|
*/
|
|
int err;
|
|
};
|
|
|
|
void hci_req_init(struct hci_request *req, struct hci_dev *hdev);
|
|
int hci_req_run(struct hci_request *req, hci_req_complete_t complete);
|
|
int hci_req_run_skb(struct hci_request *req, hci_req_complete_skb_t complete);
|
|
void hci_req_add(struct hci_request *req, u16 opcode, u32 plen,
|
|
const void *param);
|
|
void hci_req_add_ev(struct hci_request *req, u16 opcode, u32 plen,
|
|
const void *param, u8 event);
|
|
void hci_req_cmd_complete(struct hci_dev *hdev, u16 opcode, u8 status,
|
|
hci_req_complete_t *req_complete,
|
|
hci_req_complete_skb_t *req_complete_skb);
|
|
|
|
int hci_req_sync(struct hci_dev *hdev, int (*req)(struct hci_request *req,
|
|
unsigned long opt),
|
|
unsigned long opt, u32 timeout, u8 *hci_status);
|
|
int __hci_req_sync(struct hci_dev *hdev, int (*func)(struct hci_request *req,
|
|
unsigned long opt),
|
|
unsigned long opt, u32 timeout, u8 *hci_status);
|
|
void hci_req_sync_cancel(struct hci_dev *hdev, int err);
|
|
|
|
struct sk_buff *hci_prepare_cmd(struct hci_dev *hdev, u16 opcode, u32 plen,
|
|
const void *param);
|
|
|
|
void hci_req_add_le_scan_disable(struct hci_request *req);
|
|
void hci_req_add_le_passive_scan(struct hci_request *req);
|
|
|
|
/* Returns true if HCI commands were queued */
|
|
bool hci_req_stop_discovery(struct hci_request *req);
|
|
|
|
static inline void hci_req_update_scan(struct hci_dev *hdev)
|
|
{
|
|
queue_work(hdev->req_workqueue, &hdev->scan_update);
|
|
}
|
|
|
|
void __hci_req_update_scan(struct hci_request *req);
|
|
|
|
int hci_update_random_address(struct hci_request *req, bool require_privacy,
|
|
u8 *own_addr_type);
|
|
|
|
int hci_abort_conn(struct hci_conn *conn, u8 reason);
|
|
void __hci_abort_conn(struct hci_request *req, struct hci_conn *conn,
|
|
u8 reason);
|
|
|
|
static inline void hci_update_background_scan(struct hci_dev *hdev)
|
|
{
|
|
queue_work(hdev->req_workqueue, &hdev->bg_scan_update);
|
|
}
|
|
|
|
void hci_request_setup(struct hci_dev *hdev);
|
|
void hci_request_cancel_all(struct hci_dev *hdev);
|