![Alan Cox](/assets/img/avatar_default.png)
I've been chasing Jeff about this for months. Jeff added the Marvell device identifiers to the ahci driver without making the AHCI driver handle the PATA port. This means a lot of users can't use current kernels and in most distro cases can't even install. This has been going on since March 2008 for the 6121 Marvell, and late 2007 for the 6145!!! This was all pointed out at the time and repeatedly ignored. Bugs assigned to Jeff about this are ignored also. To quote Jeff in email > "Just switch the order of 'ahci' and 'pata_marvell' in > /etc/modprobe.conf, then use Fedora's tools regenerate the initrd. > See? It's not rocket science, and the current configuration can be > easily made to work for Fedora users." (Which isn't trivial, isn't end user, shouldn't be needed, and as it usually breaks at install time is in fact impossible) To quote Jeff in August 2007 > " mv-ahci-pata > Marvell 6121/6141 PATA support. Needs fixing in the 'PATA controller > command' area before it is usable, and can go upstream." Only he add the ids anyway later and caused regressions, adding a further id in March causing more regresions. The actual fix for the moment is very simple. If the user has included the pata_marvell driver let it drive the ports. If they've only selected for SATA support give them the AHCI driver which will run the port a fraction faster. Allow the user to control this decision via ahci.marvell_enable as a module parameter so that distributions can ship 'it works' defaults and smarter users (or config tools) can then flip it over it desired. Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
197 lines
4.4 KiB
C
197 lines
4.4 KiB
C
/*
|
|
* Marvell PATA driver.
|
|
*
|
|
* For the moment we drive the PATA port in legacy mode. That
|
|
* isn't making full use of the device functionality but it is
|
|
* easy to get working.
|
|
*
|
|
* (c) 2006 Red Hat <alan@redhat.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/device.h>
|
|
#include <scsi/scsi_host.h>
|
|
#include <linux/libata.h>
|
|
#include <linux/ata.h>
|
|
|
|
#define DRV_NAME "pata_marvell"
|
|
#define DRV_VERSION "0.1.6"
|
|
|
|
/**
|
|
* marvell_pata_active - check if PATA is active
|
|
* @pdev: PCI device
|
|
*
|
|
* Returns 1 if the PATA port may be active. We know how to check this
|
|
* for the 6145 but not the other devices
|
|
*/
|
|
|
|
static int marvell_pata_active(struct pci_dev *pdev)
|
|
{
|
|
int i;
|
|
u32 devices;
|
|
void __iomem *barp;
|
|
|
|
/* We don't yet know how to do this for other devices */
|
|
if (pdev->device != 0x6145)
|
|
return 1;
|
|
|
|
barp = pci_iomap(pdev, 5, 0x10);
|
|
if (barp == NULL)
|
|
return -ENOMEM;
|
|
|
|
printk("BAR5:");
|
|
for(i = 0; i <= 0x0F; i++)
|
|
printk("%02X:%02X ", i, ioread8(barp + i));
|
|
printk("\n");
|
|
|
|
devices = ioread32(barp + 0x0C);
|
|
pci_iounmap(pdev, barp);
|
|
|
|
if (devices & 0x10)
|
|
return 1;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* marvell_pre_reset - check for 40/80 pin
|
|
* @link: link
|
|
* @deadline: deadline jiffies for the operation
|
|
*
|
|
* Perform the PATA port setup we need.
|
|
*/
|
|
|
|
static int marvell_pre_reset(struct ata_link *link, unsigned long deadline)
|
|
{
|
|
struct ata_port *ap = link->ap;
|
|
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
|
|
|
|
if (pdev->device == 0x6145 && ap->port_no == 0 &&
|
|
!marvell_pata_active(pdev)) /* PATA enable ? */
|
|
return -ENOENT;
|
|
|
|
return ata_sff_prereset(link, deadline);
|
|
}
|
|
|
|
static int marvell_cable_detect(struct ata_port *ap)
|
|
{
|
|
/* Cable type */
|
|
switch(ap->port_no)
|
|
{
|
|
case 0:
|
|
if (ioread8(ap->ioaddr.bmdma_addr + 1) & 1)
|
|
return ATA_CBL_PATA40;
|
|
return ATA_CBL_PATA80;
|
|
case 1: /* Legacy SATA port */
|
|
return ATA_CBL_SATA;
|
|
}
|
|
|
|
BUG();
|
|
return 0; /* Our BUG macro needs the right markup */
|
|
}
|
|
|
|
/* No PIO or DMA methods needed for this device */
|
|
|
|
static struct scsi_host_template marvell_sht = {
|
|
ATA_BMDMA_SHT(DRV_NAME),
|
|
};
|
|
|
|
static struct ata_port_operations marvell_ops = {
|
|
.inherits = &ata_bmdma_port_ops,
|
|
.cable_detect = marvell_cable_detect,
|
|
.prereset = marvell_pre_reset,
|
|
};
|
|
|
|
|
|
/**
|
|
* marvell_init_one - Register Marvell ATA PCI device with kernel services
|
|
* @pdev: PCI device to register
|
|
* @ent: Entry in marvell_pci_tbl matching with @pdev
|
|
*
|
|
* Called from kernel PCI layer.
|
|
*
|
|
* LOCKING:
|
|
* Inherited from PCI layer (may sleep).
|
|
*
|
|
* RETURNS:
|
|
* Zero on success, or -ERRNO value.
|
|
*/
|
|
|
|
static int marvell_init_one (struct pci_dev *pdev, const struct pci_device_id *id)
|
|
{
|
|
static const struct ata_port_info info = {
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
|
|
|
.pio_mask = 0x1f,
|
|
.mwdma_mask = 0x07,
|
|
.udma_mask = ATA_UDMA5,
|
|
|
|
.port_ops = &marvell_ops,
|
|
};
|
|
static const struct ata_port_info info_sata = {
|
|
/* Slave possible as its magically mapped not real */
|
|
.flags = ATA_FLAG_SLAVE_POSS,
|
|
|
|
.pio_mask = 0x1f,
|
|
.mwdma_mask = 0x07,
|
|
.udma_mask = ATA_UDMA6,
|
|
|
|
.port_ops = &marvell_ops,
|
|
};
|
|
const struct ata_port_info *ppi[] = { &info, &info_sata };
|
|
|
|
if (pdev->device == 0x6101)
|
|
ppi[1] = &ata_dummy_port_info;
|
|
|
|
#if defined(CONFIG_AHCI) || defined(CONFIG_AHCI_MODULE)
|
|
if (!marvell_pata_active(pdev)) {
|
|
printk(KERN_INFO DRV_NAME ": PATA port not active, deferring to AHCI driver.\n");
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
return ata_pci_sff_init_one(pdev, ppi, &marvell_sht, NULL);
|
|
}
|
|
|
|
static const struct pci_device_id marvell_pci_tbl[] = {
|
|
{ PCI_DEVICE(0x11AB, 0x6101), },
|
|
{ PCI_DEVICE(0x11AB, 0x6121), },
|
|
{ PCI_DEVICE(0x11AB, 0x6123), },
|
|
{ PCI_DEVICE(0x11AB, 0x6145), },
|
|
{ } /* terminate list */
|
|
};
|
|
|
|
static struct pci_driver marvell_pci_driver = {
|
|
.name = DRV_NAME,
|
|
.id_table = marvell_pci_tbl,
|
|
.probe = marvell_init_one,
|
|
.remove = ata_pci_remove_one,
|
|
#ifdef CONFIG_PM
|
|
.suspend = ata_pci_device_suspend,
|
|
.resume = ata_pci_device_resume,
|
|
#endif
|
|
};
|
|
|
|
static int __init marvell_init(void)
|
|
{
|
|
return pci_register_driver(&marvell_pci_driver);
|
|
}
|
|
|
|
static void __exit marvell_exit(void)
|
|
{
|
|
pci_unregister_driver(&marvell_pci_driver);
|
|
}
|
|
|
|
module_init(marvell_init);
|
|
module_exit(marvell_exit);
|
|
|
|
MODULE_AUTHOR("Alan Cox");
|
|
MODULE_DESCRIPTION("SCSI low-level driver for Marvell ATA in legacy mode");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DEVICE_TABLE(pci, marvell_pci_tbl);
|
|
MODULE_VERSION(DRV_VERSION);
|
|
|