![Arnd Bergmann](/assets/img/avatar_default.png)
We cannot access the skb->_nfct field when CONFIG_NF_CONNTRACK is
disabled:
net/ipv4/netfilter/nf_defrag_ipv4.c: In function 'ipv4_conntrack_defrag':
net/ipv4/netfilter/nf_defrag_ipv4.c:83:9: error: 'struct sk_buff' has no member named '_nfct'
net/ipv6/netfilter/nf_defrag_ipv6_hooks.c: In function 'ipv6_defrag':
net/ipv6/netfilter/nf_defrag_ipv6_hooks.c:68:9: error: 'struct sk_buff' has no member named '_nfct'
Both functions already have an #ifdef for this, so let's move the
check in there.
Fixes: 902d6a4c2a
("netfilter: nf_defrag: Skip defrag if NOTRACK is set")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
164 lines
3.7 KiB
C
164 lines
3.7 KiB
C
/* (C) 1999-2001 Paul `Rusty' Russell
|
|
* (C) 2002-2004 Netfilter Core Team <coreteam@netfilter.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/ipv6.h>
|
|
#include <linux/in6.h>
|
|
#include <linux/netfilter.h>
|
|
#include <linux/module.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/icmp.h>
|
|
#include <linux/sysctl.h>
|
|
#include <net/ipv6.h>
|
|
#include <net/inet_frag.h>
|
|
|
|
#include <linux/netfilter_ipv6.h>
|
|
#include <linux/netfilter_bridge.h>
|
|
#if IS_ENABLED(CONFIG_NF_CONNTRACK)
|
|
#include <net/netfilter/nf_conntrack.h>
|
|
#include <net/netfilter/nf_conntrack_helper.h>
|
|
#include <net/netfilter/nf_conntrack_l4proto.h>
|
|
#include <net/netfilter/nf_conntrack_l3proto.h>
|
|
#include <net/netfilter/nf_conntrack_core.h>
|
|
#include <net/netfilter/ipv6/nf_conntrack_ipv6.h>
|
|
#endif
|
|
#include <net/netfilter/nf_conntrack_zones.h>
|
|
#include <net/netfilter/ipv6/nf_defrag_ipv6.h>
|
|
|
|
static DEFINE_MUTEX(defrag6_mutex);
|
|
|
|
static enum ip6_defrag_users nf_ct6_defrag_user(unsigned int hooknum,
|
|
struct sk_buff *skb)
|
|
{
|
|
u16 zone_id = NF_CT_DEFAULT_ZONE_ID;
|
|
#if IS_ENABLED(CONFIG_NF_CONNTRACK)
|
|
if (skb_nfct(skb)) {
|
|
enum ip_conntrack_info ctinfo;
|
|
const struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
|
|
|
|
zone_id = nf_ct_zone_id(nf_ct_zone(ct), CTINFO2DIR(ctinfo));
|
|
}
|
|
#endif
|
|
if (nf_bridge_in_prerouting(skb))
|
|
return IP6_DEFRAG_CONNTRACK_BRIDGE_IN + zone_id;
|
|
|
|
if (hooknum == NF_INET_PRE_ROUTING)
|
|
return IP6_DEFRAG_CONNTRACK_IN + zone_id;
|
|
else
|
|
return IP6_DEFRAG_CONNTRACK_OUT + zone_id;
|
|
}
|
|
|
|
static unsigned int ipv6_defrag(void *priv,
|
|
struct sk_buff *skb,
|
|
const struct nf_hook_state *state)
|
|
{
|
|
int err;
|
|
|
|
#if IS_ENABLED(CONFIG_NF_CONNTRACK)
|
|
/* Previously seen (loopback)? */
|
|
if (skb_nfct(skb) && !nf_ct_is_template((struct nf_conn *)skb_nfct(skb)))
|
|
return NF_ACCEPT;
|
|
|
|
if (skb->_nfct == IP_CT_UNTRACKED)
|
|
return NF_ACCEPT;
|
|
#endif
|
|
|
|
err = nf_ct_frag6_gather(state->net, skb,
|
|
nf_ct6_defrag_user(state->hook, skb));
|
|
/* queued */
|
|
if (err == -EINPROGRESS)
|
|
return NF_STOLEN;
|
|
|
|
return err == 0 ? NF_ACCEPT : NF_DROP;
|
|
}
|
|
|
|
static const struct nf_hook_ops ipv6_defrag_ops[] = {
|
|
{
|
|
.hook = ipv6_defrag,
|
|
.pf = NFPROTO_IPV6,
|
|
.hooknum = NF_INET_PRE_ROUTING,
|
|
.priority = NF_IP6_PRI_CONNTRACK_DEFRAG,
|
|
},
|
|
{
|
|
.hook = ipv6_defrag,
|
|
.pf = NFPROTO_IPV6,
|
|
.hooknum = NF_INET_LOCAL_OUT,
|
|
.priority = NF_IP6_PRI_CONNTRACK_DEFRAG,
|
|
},
|
|
};
|
|
|
|
static void __net_exit defrag6_net_exit(struct net *net)
|
|
{
|
|
if (net->nf.defrag_ipv6) {
|
|
nf_unregister_net_hooks(net, ipv6_defrag_ops,
|
|
ARRAY_SIZE(ipv6_defrag_ops));
|
|
net->nf.defrag_ipv6 = false;
|
|
}
|
|
}
|
|
|
|
static struct pernet_operations defrag6_net_ops = {
|
|
.exit = defrag6_net_exit,
|
|
};
|
|
|
|
static int __init nf_defrag_init(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
ret = nf_ct_frag6_init();
|
|
if (ret < 0) {
|
|
pr_err("nf_defrag_ipv6: can't initialize frag6.\n");
|
|
return ret;
|
|
}
|
|
ret = register_pernet_subsys(&defrag6_net_ops);
|
|
if (ret < 0) {
|
|
pr_err("nf_defrag_ipv6: can't register pernet ops\n");
|
|
goto cleanup_frag6;
|
|
}
|
|
return ret;
|
|
|
|
cleanup_frag6:
|
|
nf_ct_frag6_cleanup();
|
|
return ret;
|
|
|
|
}
|
|
|
|
static void __exit nf_defrag_fini(void)
|
|
{
|
|
unregister_pernet_subsys(&defrag6_net_ops);
|
|
nf_ct_frag6_cleanup();
|
|
}
|
|
|
|
int nf_defrag_ipv6_enable(struct net *net)
|
|
{
|
|
int err = 0;
|
|
|
|
might_sleep();
|
|
|
|
if (net->nf.defrag_ipv6)
|
|
return 0;
|
|
|
|
mutex_lock(&defrag6_mutex);
|
|
if (net->nf.defrag_ipv6)
|
|
goto out_unlock;
|
|
|
|
err = nf_register_net_hooks(net, ipv6_defrag_ops,
|
|
ARRAY_SIZE(ipv6_defrag_ops));
|
|
if (err == 0)
|
|
net->nf.defrag_ipv6 = true;
|
|
|
|
out_unlock:
|
|
mutex_unlock(&defrag6_mutex);
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_GPL(nf_defrag_ipv6_enable);
|
|
|
|
module_init(nf_defrag_init);
|
|
module_exit(nf_defrag_fini);
|
|
|
|
MODULE_LICENSE("GPL");
|