![Anton Blanchard](/assets/img/avatar_default.png)
The ppc64 kernel can get loaded at any address which means our very early init code in prom_init.c must be relocatable. We do this with a pretty nasty RELOC() macro that we wrap accesses of variables with. It is very fragile and sometimes we forget to add a RELOC() to an uncommon path or sometimes a compiler change breaks it. 32bit has a much more elegant solution where we build prom_init.c with -mrelocatable and then process the relocations manually. Unfortunately we can't do the equivalent on 64bit and we would have to build the entire kernel relocatable (-pie), resulting in a large increase in kernel footprint (megabytes of relocation data). The relocation data will be marked __initdata but it still creates more pressure on our already tight memory layout at boot. Alan Modra pointed out that the 64bit ABI is relocatable even if we don't build with -pie, we just need to relocate the TOC. This patch implements that idea and relocates the TOC entries of prom_init.c. An added bonus is there are very few relocations to process which helps keep boot times on simulators down. gcc does not put 64bit integer constants into the TOC but to be safe we may want a build time script which passes through the prom_init.c TOC entries to make sure everything looks reasonable. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
81 lines
2 KiB
Bash
81 lines
2 KiB
Bash
#!/bin/sh
|
|
#
|
|
# Copyright © 2008 IBM Corporation
|
|
#
|
|
# This program is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU General Public License
|
|
# as published by the Free Software Foundation; either version
|
|
# 2 of the License, or (at your option) any later version.
|
|
|
|
# This script checks prom_init.o to see what external symbols it
|
|
# is using, if it finds symbols not in the whitelist it returns
|
|
# an error. The point of this is to discourage people from
|
|
# intentionally or accidentally adding new code to prom_init.c
|
|
# which has side effects on other parts of the kernel.
|
|
|
|
# If you really need to reference something from prom_init.o add
|
|
# it to the list below:
|
|
|
|
WHITELIST="add_reloc_offset __bss_start __bss_stop copy_and_flush
|
|
_end enter_prom memcpy memset reloc_offset __secondary_hold
|
|
__secondary_hold_acknowledge __secondary_hold_spinloop __start
|
|
strcmp strcpy strlcpy strlen strncmp strstr logo_linux_clut224
|
|
reloc_got2 kernstart_addr memstart_addr linux_banner _stext
|
|
opal_query_takeover opal_do_takeover opal_enter_rtas opal_secondary_entry
|
|
boot_command_line __prom_init_toc_start __prom_init_toc_end"
|
|
|
|
NM="$1"
|
|
OBJ="$2"
|
|
|
|
ERROR=0
|
|
|
|
for UNDEF in $($NM -u $OBJ | awk '{print $2}')
|
|
do
|
|
# On 64-bit nm gives us the function descriptors, which have
|
|
# a leading . on the name, so strip it off here.
|
|
UNDEF="${UNDEF#.}"
|
|
|
|
if [ $KBUILD_VERBOSE ]; then
|
|
if [ $KBUILD_VERBOSE -ne 0 ]; then
|
|
echo "Checking prom_init.o symbol '$UNDEF'"
|
|
fi
|
|
fi
|
|
|
|
OK=0
|
|
for WHITE in $WHITELIST
|
|
do
|
|
if [ "$UNDEF" = "$WHITE" ]; then
|
|
OK=1
|
|
break
|
|
fi
|
|
done
|
|
|
|
# ignore register save/restore funcitons
|
|
if [ "${UNDEF:0:9}" = "_restgpr_" ]; then
|
|
OK=1
|
|
fi
|
|
if [ "${UNDEF:0:10}" = "_restgpr0_" ]; then
|
|
OK=1
|
|
fi
|
|
if [ "${UNDEF:0:11}" = "_rest32gpr_" ]; then
|
|
OK=1
|
|
fi
|
|
if [ "${UNDEF:0:9}" = "_savegpr_" ]; then
|
|
OK=1
|
|
fi
|
|
if [ "${UNDEF:0:10}" = "_savegpr0_" ]; then
|
|
OK=1
|
|
fi
|
|
if [ "${UNDEF:0:11}" = "_save32gpr_" ]; then
|
|
OK=1
|
|
fi
|
|
|
|
if [ $OK -eq 0 ]; then
|
|
ERROR=1
|
|
echo "Error: External symbol '$UNDEF' referenced" \
|
|
"from prom_init.c" >&2
|
|
fi
|
|
done
|
|
|
|
exit $ERROR
|