497888cf69
All these are instances of #define NAME value; or #define NAME(params_opt) value; These of course fail to build when used in contexts like if(foo $OP NAME) while(bar $OP NAME) and may silently generate the wrong code in contexts such as foo = NAME + 1; /* foo = value; + 1; */ bar = NAME - 1; /* bar = value; - 1; */ baz = NAME & quux; /* baz = value; & quux; */ Reported on comp.lang.c, Message-ID: <ab0d55fe-25e5-482b-811e-c475aa6065c3@c29g2000yqd.googlegroups.com> Initial analysis of the dangers provided by Keith Thompson in that thread. There are many more instances of more complicated macros having unnecessary trailing semicolons, but this pile seems to be all of the cases of simple values suffering from the problem. (Thus things that are likely to be found in one of the contexts above, more complicated ones aren't.) Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
74 lines
2.4 KiB
C
74 lines
2.4 KiB
C
/* sis_drv.h -- Private header for sis driver -*- linux-c -*- */
|
|
/*
|
|
* Copyright 1999 Precision Insight, Inc., Cedar Park, Texas.
|
|
* Copyright 2000 VA Linux Systems, Inc., Sunnyvale, California.
|
|
* All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#ifndef _SIS_DRV_H_
|
|
#define _SIS_DRV_H_
|
|
|
|
/* General customization:
|
|
*/
|
|
|
|
#define DRIVER_AUTHOR "SIS, Tungsten Graphics"
|
|
#define DRIVER_NAME "sis"
|
|
#define DRIVER_DESC "SIS 300/630/540 and XGI V3XE/V5/V8"
|
|
#define DRIVER_DATE "20070626"
|
|
#define DRIVER_MAJOR 1
|
|
#define DRIVER_MINOR 3
|
|
#define DRIVER_PATCHLEVEL 0
|
|
|
|
enum sis_family {
|
|
SIS_OTHER = 0,
|
|
SIS_CHIP_315 = 1,
|
|
};
|
|
|
|
#include "drm_sman.h"
|
|
|
|
|
|
#define SIS_BASE (dev_priv->mmio)
|
|
#define SIS_READ(reg) DRM_READ32(SIS_BASE, reg)
|
|
#define SIS_WRITE(reg, val) DRM_WRITE32(SIS_BASE, reg, val)
|
|
|
|
typedef struct drm_sis_private {
|
|
drm_local_map_t *mmio;
|
|
unsigned int idle_fault;
|
|
struct drm_sman sman;
|
|
unsigned int chipset;
|
|
int vram_initialized;
|
|
int agp_initialized;
|
|
unsigned long vram_offset;
|
|
unsigned long agp_offset;
|
|
} drm_sis_private_t;
|
|
|
|
extern int sis_idle(struct drm_device *dev);
|
|
extern void sis_reclaim_buffers_locked(struct drm_device *dev,
|
|
struct drm_file *file_priv);
|
|
extern void sis_lastclose(struct drm_device *dev);
|
|
|
|
extern struct drm_ioctl_desc sis_ioctls[];
|
|
extern int sis_max_ioctl;
|
|
|
|
#endif
|