alistair23-linux/drivers
Tony Lindgren 0b2aa8bed3 gpio: twl4030: Fix regression for twl gpio output
Commit c111feabe2 (gpio: twl4030: Cache the direction and output
states in private data) improved things in general, but caused a
regression for setting the GPIO output direction.

The change reorganized twl_direction_out() and twl_set() and swapped
the function names around in the process. While doing that, a bug got
introduced that's not obvious while reading the patch as it appears
as no change to the code.

The bug is we now call function twl4030_set_gpio_dataout() twice in
both twl_direction_out() and twl_set(). Instead, we should first
call twl_direction_out() in twl_direction_out() followed by
twl4030_set_gpio_dataout() in twl_set().

This regression probably has gone unnoticed for a long time as the
bootloader may have set the GPIO direction properly in many cases.
This fixes at least the LCD panel not turning on omap3 LDP for
example.

Cc: linux-gpio@vger.kernel.org
Cc: stable@vger.kernel.org #v3.9+
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
2013-11-18 15:22:59 -08:00
..
accessibility
acpi Merge branch 'x86-mce-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2013-11-12 11:16:44 +09:00
amba
ata DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
atm
auxdisplay
base regmap: Updates for v3.13 2013-11-12 14:47:00 +09:00
bcma
block
bluetooth
bus ARM: driver updates for 3.13 2013-11-11 17:05:37 +09:00
cdrom
char DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
clk DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
clocksource
connector
cpufreq DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
cpuidle
crypto powerpc: add missing explicit OF includes for ppc 2013-11-11 09:10:50 -06:00
dca
devfreq
dio
dma DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
edac DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
eisa
extcon
firewire
firmware Merge branch 'x86-mce-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2013-11-12 11:16:44 +09:00
fmc
gpio gpio: twl4030: Fix regression for twl gpio output 2013-11-18 15:22:59 -08:00
gpu Merge branch 'x86-intel-mid-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2013-11-12 11:12:22 +09:00
hid Staging driver update for 3.13-rc1 2013-11-07 15:07:58 +09:00
hsi
hv
hwmon spi: Updates for v3.13 2013-11-12 15:01:39 +09:00
hwspinlock
i2c i2c: omap: Fix missing device tree flags for omap2 2013-11-15 14:32:34 -08:00
ide H8/300 has been dead for several years, the kernel for it has 2013-11-12 14:13:14 +09:00
idle
iio
infiniband
input DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
iommu
ipack
irqchip Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2013-11-12 10:02:59 +09:00
isdn
leds
lguest
macintosh DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
mailbox
md Driver Core / sysfs patches for 3.13-rc1 2013-11-07 11:42:15 +09:00
media DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
memory
memstick
message
mfd sound updates for 3.13-rc1 2013-11-12 15:29:53 +09:00
misc DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
mmc
mtd DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
net DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
nfc
ntb
nubus
of DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
oprofile
parisc
parport H8/300 has been dead for several years, the kernel for it has 2013-11-12 14:13:14 +09:00
pci DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
pcmcia DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
phy
pinctrl pinctrl: single: call pcs_soc->rearm() whenever IRQ mask is changed 2013-11-14 10:43:17 -08:00
platform sound updates for 3.13-rc1 2013-11-12 15:29:53 +09:00
pnp
power
pps
ps3
ptp
pwm
rapidio
regulator
remoteproc
reset
rpmsg
rtc DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
s390 s390/scm_blk: fix endless loop for requests != REQ_TYPE_FS 2013-11-06 14:32:22 +01:00
sbus
scsi Driver Core / sysfs patches for 3.13-rc1 2013-11-07 11:42:15 +09:00
sfi
sh
sn
spi DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
ssb
staging GPIO bulk changes for the v3.13 development cycle 2013-11-12 15:50:46 +09:00
target
tc
thermal
tty DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
uio Char/Misc patches for 3.13-rc1 2013-11-07 09:41:06 +09:00
usb DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
uwb Driver Core / sysfs patches for 3.13-rc1 2013-11-07 11:42:15 +09:00
vfio
vhost
video DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
virt
virtio
vlynq
vme
w1 w1-gpio: Use devm_* functions 2013-10-29 16:58:18 -07:00
watchdog DeviceTree updates for 3.13. This is a bit larger pull request than 2013-11-12 16:52:17 +09:00
xen
zorro
Kconfig
Makefile