![Andrew Lunn](/assets/img/avatar_default.png)
Before this change of_get_phy_mode() returned an enum, phy_interface_t. On error, -ENODEV etc, is returned. If the result of the function is stored in a variable of type phy_interface_t, and the compiler has decided to represent this as an unsigned int, comparision with -ENODEV etc, is a signed vs unsigned comparision. Fix this problem by changing the API. Make the function return an error, or 0 on success, and pass a pointer, of type phy_interface_t, where the phy mode should be stored. v2: Return with *interface set to PHY_INTERFACE_MODE_NA on error. Add error checks to all users of of_get_phy_mode() Fixup a few reverse christmas tree errors Fixup a few slightly malformed reverse christmas trees v3: Fix 0-day reported errors. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
54 lines
1.2 KiB
C
54 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* 10G controller driver for Samsung EXYNOS SoCs
|
|
*
|
|
* Copyright (C) 2013 Samsung Electronics Co., Ltd.
|
|
* http://www.samsung.com
|
|
*
|
|
* Author: Siva Reddy Kallam <siva.kallam@samsung.com>
|
|
*/
|
|
#ifndef __SXGBE_PLATFORM_H__
|
|
#define __SXGBE_PLATFORM_H__
|
|
|
|
#include <linux/phy.h>
|
|
|
|
/* MDC Clock Selection define*/
|
|
#define SXGBE_CSR_100_150M 0x0 /* MDC = clk_scr_i/62 */
|
|
#define SXGBE_CSR_150_250M 0x1 /* MDC = clk_scr_i/102 */
|
|
#define SXGBE_CSR_250_300M 0x2 /* MDC = clk_scr_i/122 */
|
|
#define SXGBE_CSR_300_350M 0x3 /* MDC = clk_scr_i/142 */
|
|
#define SXGBE_CSR_350_400M 0x4 /* MDC = clk_scr_i/162 */
|
|
#define SXGBE_CSR_400_500M 0x5 /* MDC = clk_scr_i/202 */
|
|
|
|
/* Platfrom data for platform device structure's
|
|
* platform_data field
|
|
*/
|
|
struct sxgbe_mdio_bus_data {
|
|
unsigned int phy_mask;
|
|
int *irqs;
|
|
int probed_phy_irq;
|
|
};
|
|
|
|
struct sxgbe_dma_cfg {
|
|
int pbl;
|
|
int fixed_burst;
|
|
int burst_map;
|
|
int adv_addr_mode;
|
|
};
|
|
|
|
struct sxgbe_plat_data {
|
|
char *phy_bus_name;
|
|
int bus_id;
|
|
int phy_addr;
|
|
phy_interface_t interface;
|
|
struct sxgbe_mdio_bus_data *mdio_bus_data;
|
|
struct sxgbe_dma_cfg *dma_cfg;
|
|
int clk_csr;
|
|
int pmt;
|
|
int force_sf_dma_mode;
|
|
int force_thresh_dma_mode;
|
|
int riwt_off;
|
|
};
|
|
|
|
#endif /* __SXGBE_PLATFORM_H__ */
|